netdev - Re: [PATCH v2 0/5] dd ethernet support for RPi5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251031114518.GA17287@pendragon.ideasonboard.com>
Date: Fri, 31 Oct 2025 13:45:18 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Stanimir Varbanov <svarbanov@...e.de>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-rpi-kernel@...ts.infradead.org,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Andrea della Porta <andrea.porta@...e.com>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Phil Elwell <phil@...pberrypi.com>,
	Jonathan Bell <jonathan@...pberrypi.com>,
	Dave Stevenson <dave.stevenson@...pberrypi.com>
Subject: Re: [PATCH v2 0/5] dd ethernet support for RPi5

Hi Stan,

On Fri, Aug 22, 2025 at 12:34:35PM +0300, Stanimir Varbanov wrote:
> Hello,
> 
> Changes in v2:
>  - In 1/5 updates according to review comments (Nicolas)
>  - In 1/5 added Fixes tag (Nicolas)
>  - Added Reviewed-by and Acked-by tags.
> 
> v1 can found at [1].
> 
> Comments are welcome!

I'm very happy to see support for Raspberry Pi 5 progressing fast
upstream.

I've tested the latest mainline kernel (v6.18-rc3) that includes this
series (except for 1/5 that is replaced by
https://lore.kernel.org/all/20250820-macb-fixes-v4-0-23c399429164@bootlin.com/
as far as I understand). The ethernet controller is successfully
detected, and so is the PHY. Link status seems to work fine too, but
data doesn't seem to go through when the kernel tries to get a DHCP
address (for NFS root). Here's the end of the kernel log (with the
messages related to the USB controller stripped out):

[    0.896779] rp1_pci 0002:01:00.0: assign IRQ: got 27
[    0.896809] rp1_pci 0002:01:00.0: enabling device (0000 -> 0002)
[    0.896840] rp1_pci 0002:01:00.0: enabling bus mastering
[    0.931874] macb 1f00100000.ethernet: invalid hw address, using random
[    0.944448] macb 1f00100000.ethernet eth0: Cadence GEM rev 0x00070109 at 0x1f00100000 irq 95 (da:2e:6d:9d:52:a4)
[    0.989067] macb 1f00100000.ethernet eth0: PHY [1f00100000.ethernet-ffffffff:01] driver [Broadcom BCM54210E] (irq=POLL)
[    0.989272] macb 1f00100000.ethernet eth0: configuring for phy/rgmii-id link mode
[    0.991271] macb 1f00100000.ethernet: gem-ptp-timer ptp clock registered.
[    4.039490] macb 1f00100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control tx
[    4.062589] Sending DHCP requests .....
[   40.902771] macb 1f00100000.ethernet eth0: Link is Down
[   43.975334] macb 1f00100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control tx

I've tried porting patches to drivers/net/phy/broadcom.c from the
Raspberry Pi kernel to specifically support the BCM54213PE PHY (which is
otherwise identified as a BCM54210E), but they didn't seem to help.

What's the status of ethernet support on the Pi 5, is it supposed to
work upstream, or are there pieces still missing ?

> [1] www.spinics.net/lists/netdev/msg1115266.html
> 
> Dave Stevenson (2):
>   dt-bindings: net: cdns,macb: Add compatible for Raspberry Pi RP1
>   net: cadence: macb: Add support for Raspberry Pi RP1 ethernet
>     controller
> 
> Stanimir Varbanov (3):
>   net: cadence: macb: Set upper 32bits of DMA ring buffer
>   arm64: dts: rp1: Add ethernet DT node
>   arm64: dts: broadcom: Enable RP1 ethernet for Raspberry Pi 5
> 
>  .../devicetree/bindings/net/cdns,macb.yaml     |  1 +
>  .../boot/dts/broadcom/bcm2712-rpi-5-b.dts      | 18 ++++++++++++++++++
>  arch/arm64/boot/dts/broadcom/rp1-common.dtsi   | 16 ++++++++++++++++
>  drivers/net/ethernet/cadence/macb_main.c       | 18 +++++++++++++++++-
>  4 files changed, 52 insertions(+), 1 deletion(-)

-- 
Regards,

Laurent Pinchart