netdev - RE: [PATCH net-next 2/6] net: fec: register a fixed phy using fixed_phy_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB851024F31700200CC78CE60988F8A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Fri, 31 Oct 2025 03:36:43 +0000
From: Wei Fang <wei.fang@....com>
To: Heiner Kallweit <hkallweit1@...il.com>
CC: "linux-m68k@...ts.linux-m68k.org" <linux-m68k@...ts.linux-m68k.org>,
	"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Greg Ungerer <gerg@...ux-m68k.org>, Geert
 Uytterhoeven <geert@...ux-m68k.org>, Hauke Mehrtens <hauke@...ke-m.de>,
	Rafał Miłecki <zajec5@...il.com>, Thomas Bogendoerfer
	<tsbogend@...ha.franken.de>, Michael Chan <michael.chan@...adcom.com>,
	Shenwei Wang <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>,
	Russell King - ARM Linux <linux@...linux.org.uk>, Andrew Lunn
	<andrew@...n.ch>, Andrew Lunn <andrew+netdev@...n.ch>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, David Miller
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>
Subject: RE: [PATCH net-next 2/6] net: fec: register a fixed phy using
 fixed_phy_register_100fd if needed

> Note 2: Usage of phy_find_next() makes use of the fact that dev_id can
> only be 0 or 1.
> 
I'm not familiar with the ColdFire platforms. Do these platforms only have
a maximum of two FEC ports?

The logic below doesn't show a maximum of two FEC ports.

for (phy_id = 0; (phy_id < PHY_MAX_ADDR); phy_id++) {
	if (!mdiobus_is_registered_device(fep->mii_bus, phy_id))
		continue;
	if (dev_id--)
		continue;
	strscpy(mdio_bus_id, fep->mii_bus->id, MII_BUS_ID_SIZE);
	break;
}