netdev - RE: [Intel-wired-lan] [PATCH iwl-net v2] libie: depend on DEBUG_FS when building LIBIE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6241E6F1E6CBB17B3B7958228BF8A@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Fri, 31 Oct 2025 09:08:10 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>, Guenter Roeck <linux@...ck-us.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v2] libie: depend on DEBUG_FS
 when building LIBIE_FWLOG

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Michal Swiatkowski
> Sent: 16 October 2025 13:00
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Keller, Jacob E <jacob.e.keller@...el.com>; Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>; Guenter Roeck <linux@...ck-us.net>
> Subject: [Intel-wired-lan] [PATCH iwl-net v2] libie: depend on DEBUG_FS when building LIBIE_FWLOG
>
> LIBIE_FWLOG is unusable without DEBUG_FS. Mark it in Kconfig.
>
> Fix build error on ixgbe when DEBUG_FS is not set. To not add another layer of #if IS_ENABLED(LIBIE_FWLOG) in ixgbe fwlog code define debugfs dentry even when DEBUG_FS isn't enabled. In this case the dummy functions of LIBIE_FWLOG will be used, so not initialized dentry isn't a problem.
>
> Fixes: 641585bc978e ("ixgbe: fwlog support for e610")
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Closes: https://lore.kernel.org/lkml/f594c621-f9e1-49f2-af31-23fbcb176058@roeck-us.net/
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
> v1 --> v2 [1]:
> * add DEBUG_FS dependency in LIBIE_FWLOG
>
> [1] https://lore.kernel.org/netdev/20251014141110.751104-1-michal.swiatkowski@linux.intel.com/
> ---
> drivers/net/ethernet/intel/Kconfig       |  4 ++--
> drivers/net/ethernet/intel/ixgbe/ixgbe.h |  2 --
> include/linux/net/intel/libie/fwlog.h    | 12 ++++++++++++
> 3 files changed, 14 insertions(+), 4 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)