netdev - Re: [PATCH v5 1/3] dt-bindings: net: sophgo,sg2044-dwmac: add phy mode restriction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <176190898726.569389.4934903700571310952.robh@kernel.org>
Date: Fri, 31 Oct 2025 06:09:47 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Russell King <linux@...linux.org.uk>, 
 Conor Dooley <conor.dooley@...rochip.com>, Paolo Abeni <pabeni@...hat.com>, 
 Conor Dooley <conor+dt@...nel.org>, 
 linux-stm32@...md-mailman.stormreply.com, 
 "David S. Miller" <davem@...emloft.net>, Longbin Li <looong.bin@...il.com>, 
 Heiner Kallweit <hkallweit1@...il.com>, 
 "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, 
 Han Gao <rabenda.cn@...il.com>, devicetree@...r.kernel.org, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Icenowy Zheng <uwu@...nowy.me>, 
 Maxime Coquelin <mcoquelin.stm32@...il.com>, 
 Chen Wang <unicorn_wang@...look.com>, Eric Dumazet <edumazet@...gle.com>, 
 sophgo@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
 Vivian Wang <wangruikang@...as.ac.cn>, Yixun Lan <dlan@...too.org>, 
 Andrew Lunn <andrew+netdev@...n.ch>, Jakub Kicinski <kuba@...nel.org>, 
 linux-kernel@...r.kernel.org, 
 Alexandre Torgue <alexandre.torgue@...s.st.com>, netdev@...r.kernel.org, 
 Yao Zi <ziyao@...root.org>
Subject: Re: [PATCH v5 1/3] dt-bindings: net: sophgo,sg2044-dwmac: add phy
 mode restriction

On Fri, 31 Oct 2025 09:24:26 +0800, Inochi Amaoto wrote:
> As the ethernet controller of SG2044 and SG2042 only supports
> RGMII phy. Add phy-mode property to restrict the value.
> 
> Also, since SG2042 has internal rx delay in its mac, make
> only "rgmii-txid" and "rgmii-id" valid for phy-mode.
> 
> Fixes: e281c48a7336 ("dt-bindings: net: sophgo,sg2044-dwmac: Add support for Sophgo SG2042 dwmac")
> Signed-off-by: Inochi Amaoto <inochiama@...il.com>
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
>  .../bindings/net/sophgo,sg2044-dwmac.yaml     | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml:93:1: [warning] too many blank lines (2 > 1) (empty-lines)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251031012428.488184-2-inochiama@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.