netdev - Re: [PATCH net-next v2] net: stmmac: qcom-ethqos: remove MAC_CTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176195520650.673072.17303889570192464247.git-patchwork-notify@kernel.org>
Date: Sat, 01 Nov 2025 00:00:06 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
Cc: andrew@...n.ch, hkallweit1@...il.com, alexandre.torgue@...s.st.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, linux-arm-kernel@...ts.infradead.org,
 linux-arm-msm@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 mcoquelin.stm32@...il.com, netdev@...r.kernel.org, pabeni@...hat.com,
 vkoul@...nel.org
Subject: Re: [PATCH net-next v2] net: stmmac: qcom-ethqos: remove MAC_CTRL_REG
 modification

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 30 Oct 2025 10:20:32 +0000 you wrote:
> When operating in "SGMII" mode (Cisco SGMII or 2500BASE-X), qcom-ethqos
> modifies the MAC control register in its ethqos_configure_sgmii()
> function, which is only called from one path:
> 
> stmmac_mac_link_up()
> +- reads MAC_CTRL_REG
> +- masks out priv->hw->link.speed_mask
> +- sets bits according to speed (2500, 1000, 100, 10) from priv->hw.link.speed*
> +- ethqos_fix_mac_speed()
> |  +- qcom_ethqos_set_sgmii_loopback(false)
> |  +- ethqos_update_link_clk(speed)
> |  `- ethqos_configure(speed)
> |     `- ethqos_configure_sgmii(speed)
> |        +- reads MAC_CTRL_REG,
> |        +- configures PS/FES bits according to speed
> |        `- writes MAC_CTRL_REG as the last operation
> +- sets duplex bit(s)
> +- stmmac_mac_flow_ctrl()
> +- writes MAC_CTRL_REG if changed from original read
> ...
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: stmmac: qcom-ethqos: remove MAC_CTRL_REG modification
    https://git.kernel.org/netdev/net-next/c/9b443e58a896

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html