netdev - Re: [PATCH net-next] hinic3: fix misleading error message in hinic3_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251103110003.835-1-gongfan1@huawei.com>
Date: Mon, 3 Nov 2025 19:00:03 +0800
From: Fan Gong <gongfan1@...wei.com>
To: <alok.a.tiwari@...cle.com>
CC: <alok.a.tiwarilinux@...il.com>, <andrew+netdev@...n.ch>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <gongfan1@...wei.com>,
	<horms@...nel.org>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <zhuyikai1@...artners.com>
Subject: Re: [PATCH net-next] hinic3: fix misleading error message in hinic3_open_channel()

On 10/31/2025 7:26 PM, Alok Tiwari wrote:
> The error message printed when hinic3_configure() fails incorrectly
> reports "Failed to init txrxq irq", which does not match the actual
> operation performed. The hinic3_configure() function sets up various
> device resources such as MTU and RSS parameters , not IRQ initialization.
>
> Update the log to "Failed to configure device resources" to make the
> message accurate and clearer for debugging.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
> Fixes: b83bb584bc97 ("hinic3: Tx & Rx configuration")
> ---
>  drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c b/drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c
> index 0fa3c7900225..bbf22811a029 100644
> --- a/drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c
> @@ -304,7 +304,7 @@ static int hinic3_open_channel(struct net_device *netdev)
>  
>  	err = hinic3_configure(netdev);
>  	if (err) {
> -		netdev_err(netdev, "Failed to init txrxq irq\n");
> +		netdev_err(netdev, "Failed to configure device resources\n");
>  		goto err_uninit_qps_irq;
>  	}
>  

Thanks for your change.

Reviewed-by: Fan Gong <gongfan1@...wei.com>