netdev - Re: [PATCH 1/2] arm: dts: ti: Adds device tree nodes for PRU Cores, IEP and eCAP modules of PRU-ICSS2 Instance.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1460283559.152037.1762168111145.JavaMail.zimbra@couthit.local>
Date: Mon, 3 Nov 2025 16:38:31 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: tony <tony@...mide.com>, robh <robh@...nel.org>, 
	krzk+dt <krzk+dt@...nel.org>, conor+dt <conor+dt@...nel.org>, 
	richardcochran <richardcochran@...il.com>, 
	linux-omap <linux-omap@...r.kernel.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	netdev <netdev@...r.kernel.org>, danishanwar <danishanwar@...com>, 
	pratheesh <pratheesh@...com>, Prajith Jayarajan <prajith@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, praneeth <praneeth@...com>, 
	srk <srk@...com>, rogerq <rogerq@...com>, 
	krishna <krishna@...thit.com>, mohan <mohan@...thit.com>, 
	pmohan <pmohan@...thit.com>, basharath <basharath@...thit.com>, 
	afd <afd@...com>, m-karicheri2 <m-karicheri2@...com>
Subject: Re: [PATCH 1/2] arm: dts: ti: Adds device tree nodes for PRU Cores,
 IEP and eCAP modules of PRU-ICSS2 Instance.

Hi,

>>> +				interrupt-names = "rx", "emac_ptp_tx",
>>> +								"hsr_ptp_tx";
>> 
>> Something looks wrong with the indentation here. The same happens in
>> at least one other place.
>> 
> 
> we will correct the indentation of the interrupt-names property to properly
> align the continuation line as shown below.
> 
> interrupt-names = "rx", "emac_ptp_tx",
>                  "hsr_ptp_tx";
> 
> We will make sure to address this in all the applicable places and include
> this fix in the next version.
> 
> 
>>> +&pruss2_mdio {
>>> +	status = "okay";
>>> +	pruss2_eth0_phy: ethernet-phy@0 {
>>> +		reg = <0>;
>>> +		interrupt-parent = <&gpio3>;
>>> +		interrupts = <30 IRQ_TYPE_EDGE_FALLING>;
>>> +	};
>>> +
>>> +	pruss2_eth1_phy: ethernet-phy@1 {
>>> +		reg = <1>;
>>> +		interrupt-parent = <&gpio3>;
>>> +		interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
>>> +	};
>> 
>> 
>> PHY interrupts are 99% level, not edge, because they represent an
>> interrupt controller in the PHY, and you need to clear all the
>> interrupts in the controller before it deasserts the interrupt pin.
>> 
>>    Andrew
> 
> 
> Sure, we will check and come back with more details on this.
> 
> 

We have reviewed and analysed the code, and confirmed that level
low can be used for the PHY interrupt, which seems to be a better
option than using the edge falling.

As shown below, the current interrupt configuration reflects a
level-triggered setup:

root@...7xx-evm:~# cat /proc/interrupts
           CPU0       CPU1    
163:          2          0 48057000.gpio  30 Level     4b2b2400.mdio:00
164:          2          0 48057000.gpio  31 Level     4b2b2400.mdio:01

We can see the IRQ has been changed to Level and the count is incremented
for every link event.

We will update the interrupt type to IRQ_TYPE_LEVEL_LOW as shown below and
share the next version.

+&pruss2_mdio {
+       status = "okay";
+       pruss2_eth0_phy: ethernet-phy@0 {
+               reg = <0>;
+               interrupt-parent = <&gpio3>;
+               interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
+       };
+
+       pruss2_eth1_phy: ethernet-phy@1 {
+               reg = <1>;
+               interrupt-parent = <&gpio3>;
+               interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
+       };
+};


Thanks and Regards,
Parvathi.