netdev - Re: [PATCH net-next v2 1/2] devlink: pass extack through to devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251103141356.3470701b@kernel.org>
Date: Mon, 3 Nov 2025 14:13:56 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Zahka <daniel.zahka@...il.com>
Cc: Jiri Pirko <jiri@...nulli.us>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>, Srujana Challa
 <schalla@...vell.com>, Bharat Bhushan <bbhushan2@...vell.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, Brett Creeley <brett.creeley@....com>,
 Andrew Lunn <andrew+netdev@...n.ch>, Michael Chan
 <michael.chan@...adcom.com>, Pavan Chebbi <pavan.chebbi@...adcom.com>, Tony
 Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Sunil Goutham <sgoutham@...vell.com>, Linu
 Cherian <lcherian@...vell.com>, Geetha sowjanya <gakula@...vell.com>, Jerin
 Jacob <jerinj@...vell.com>, hariprasad <hkelam@...vell.com>, Subbaraya
 Sundeep <sbhatta@...vell.com>, Tariq Toukan <tariqt@...dia.com>, Saeed
 Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, Mark Bloch
 <mbloch@...dia.com>, Ido Schimmel <idosch@...dia.com>, Petr Machata
 <petrm@...dia.com>, Manish Chopra <manishc@...vell.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Siddharth Vadapalli <s-vadapalli@...com>,
 Roger Quadros <rogerq@...nel.org>, Loic Poulain
 <loic.poulain@....qualcomm.com>, Sergey Ryazanov <ryazanov.s.a@...il.com>,
 Johannes Berg <johannes@...solutions.net>, Vladimir Oltean
 <olteanv@...il.com>, Michal Swiatkowski
 <michal.swiatkowski@...ux.intel.com>, Aleksandr Loktionov
 <aleksandr.loktionov@...el.com>, Dave Ertman <david.m.ertman@...el.com>,
 Vlad Dumitrescu <vdumitrescu@...dia.com>, "Russell King (Oracle)"
 <rmk+kernel@...linux.org.uk>, Alexander Sverdlin
 <alexander.sverdlin@...il.com>, Lorenzo Bianconi <lorenzo@...nel.org>,
 netdev@...r.kernel.org, linux-doc@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, linux-rdma@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] devlink: pass extack through to
 devlink_param::get()

On Mon,  3 Nov 2025 11:45:52 -0800 Daniel Zahka wrote:
> Allow devlink_param::get() handlers to report error messages via
> extack. This function is called in a few different contexts, but not
> all of them will have an valid extack to use.
> 
> When devlink_param::get() is called from param_get_doit or
> param_get_dumpit contexts, pass the extack through so that drivers can
> report errors when retrieving param values. devlink_param::get() is
> called from the context of devlink_param_notify(), pass NULL in for
> the extack.

Warning: drivers/net/ethernet/intel/ice/devlink/devlink.c:618 function parameter 'extack' not described in 'ice_devlink_tx_sched_layers_get'
Warning: drivers/net/ethernet/intel/ice/devlink/devlink.c:1533 function parameter 'extack' not described in 'ice_devlink_local_fwd_get'
-- 
pw-bot: cr