netdev - Re: [PATCH net-next v1 1/1] treewide: Rename ERR_PTR_PCPU() --> PCPU_ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQhaobur-9j6ye0m@smile.fi.intel.com>
Date: Mon, 3 Nov 2025 09:32:49 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Raag Jadav <raag.jadav@...el.com>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	Florian Westphal <fw@...len.de>, Phil Sutter <phil@....cc>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next v1 1/1] treewide: Rename ERR_PTR_PCPU() -->
 PCPU_ERR_PTR()

On Fri, Oct 31, 2025 at 04:49:58PM -0700, Jakub Kicinski wrote:
> On Thu, 30 Oct 2025 09:35:53 +0100 Andy Shevchenko wrote:
> > Make the namespace of specific ERR_PTR() macro leading the thing.
> > This is already done for IOMEM_ERR_PTR(). Follow the same pattern
> > in PCPU_ERR_PTR().
> 
> TBH I find the current naming to be typical. _PCPU() is the "flavor" of
> the API. Same as we usually append _rcu() to functions which expect
> to operate under RCU. All error pointer helpers end with _PCPU().

Ah, there is also IS_ERR_PCPU()...

> I don't feel strongly so fine if anyone else wants to apply this.
> But I will not :)

OK.

-- 
With Best Regards,
Andy Shevchenko