netdev - Re: [PATCH net-next v6 06/12] dt-bindings: net: dsa: lantiq,gswip: add MaxLinear RMII refclk output property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251103-festive-aloof-nuthatch-fadd08@kuoka>
Date: Mon, 3 Nov 2025 09:22:38 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Hauke Mehrtens <hauke@...ke-m.de>, Andrew Lunn <andrew@...n.ch>, 
	Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Simon Horman <horms@...nel.org>, Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Andreas Schirm <andreas.schirm@...mens.com>, Lukas Stockmann <lukas.stockmann@...mens.com>, 
	Alexander Sverdlin <alexander.sverdlin@...mens.com>, Peter Christen <peter.christen@...mens.com>, 
	Avinash Jayaraman <ajayaraman@...linear.com>, Bing tao Xu <bxu@...linear.com>, Liang Xu <lxu@...linear.com>, 
	Juraj Povazanec <jpovazanec@...linear.com>, "Fanni (Fang-Yi) Chan" <fchan@...linear.com>, 
	"Benny (Ying-Tsan) Weng" <yweng@...linear.com>, "Livia M. Rosu" <lrosu@...linear.com>, 
	John Crispin <john@...ozen.org>
Subject: Re: [PATCH net-next v6 06/12] dt-bindings: net: dsa: lantiq,gswip:
 add MaxLinear RMII refclk output property

On Fri, Oct 31, 2025 at 07:21:30PM +0000, Daniel Golle wrote:
> Add support for the maxlinear,rmii-refclk-out boolean property on port
> nodes to configure the RMII reference clock to be an output rather than
> an input.
> 
> This property is only applicable for ports in RMII mode and allows the
> switch to provide the reference clock for RMII-connected PHYs instead
> of requiring an external clock source.
> 
> This corresponds to the driver changes that read this Device Tree
> property to configure the RMII clock direction.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> ---
> v6:
>  * switch order of patches, move deviation from
>    dsa.yaml#/$defs/ethernet-ports to this patch which actually
>    needs it

and v5, v4, v3, v2 ? No lore links in the cover letter, incomplete
changelog.

> 
>  .../bindings/net/dsa/lantiq,gswip.yaml         | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> index f3154b19af78..b494f414a3e1 100644
> --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> @@ -6,8 +6,22 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
>  title: Lantiq GSWIP Ethernet switches
>  
> -allOf:
> -  - $ref: dsa.yaml#/$defs/ethernet-ports
> +$ref: dsa.yaml#
> +
> +patternProperties:

patterns follow properties. Please do not introduce your own style, see
example schema.

> +  "^(ethernet-)?ports$":
> +    type: object
> +    patternProperties:
> +      "^(ethernet-)?port@[0-6]$":
> +        $ref: dsa-port.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          maxlinear,rmii-refclk-out:
> +            type: boolean
> +            description:
> +              Configure the RMII reference clock to be a clock output
> +              rather than an input. Only applicable for RMII mode.
>  
>  maintainers:
>    - Hauke Mehrtens <hauke@...ke-m.de>
> -- 
> 2.51.2