netdev - Re: [PATCH v2 14/15] arm64: dts: mediatek: mt7981b-openwrt-one: Enable wifi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cba2013-0f01-40ab-9d3b-10f4bc3f02f3@collabora.com>
Date: Mon, 3 Nov 2025 09:44:27 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Sjoerd Simons <sjoerd@...labora.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Ryder Lee <ryder.lee@...iatek.com>, Jianjun Wang
 <jianjun.wang@...iatek.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>,
 Chunfeng Yun <chunfeng.yun@...iatek.com>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>, Lee Jones <lee@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Felix Fietkau <nbd@....name>
Cc: kernel@...labora.com, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-pci@...r.kernel.org,
 linux-phy@...ts.infradead.org, netdev@...r.kernel.org,
 Daniel Golle <daniel@...rotopia.org>, Bryan Hinton <bryan@...anhinton.com>
Subject: Re: [PATCH v2 14/15] arm64: dts: mediatek: mt7981b-openwrt-one:
 Enable wifi

Il 01/11/25 14:32, Sjoerd Simons ha scritto:
> Enable Dual-band WiFI 6 functionality on the Openwrt One
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Signed-off-by: Sjoerd Simons <sjoerd@...labora.com>
> ---
> V1 -> V2: Update eeprom node label
> ---
>   .../boot/dts/mediatek/mt7981b-openwrt-one.dts      | 24 ++++++++++++++++++++++
>   arch/arm64/boot/dts/mediatek/mt7981b.dtsi          |  2 +-
>   2 files changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts b/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts
> index 90edb9f493c6d..b13f16d7816bf 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts
> @@ -129,6 +129,22 @@ conf-pd {
>   			pins = "SPI2_CLK", "SPI2_MOSI", "SPI2_MISO";
>   		};
>   	};
> +
> +	wifi_dbdc_pins: wifi-dbdc-pins {
> +		mux {
> +			function = "eth";
> +			groups = "wf0_mode1";
> +		};
> +
> +		conf {
> +			pins = "WF_HB1", "WF_HB2", "WF_HB3", "WF_HB4",
> +			       "WF_HB0", "WF_HB0_B", "WF_HB5", "WF_HB6",
> +			       "WF_HB7", "WF_HB8", "WF_HB9", "WF_HB10",
> +			       "WF_TOP_CLK", "WF_TOP_DATA", "WF_XO_REQ",
> +			       "WF_CBA_RESETB", "WF_DIG_RESETB";
> +			drive-strength = <MTK_DRIVE_4mA>;

You forgot to address my comment here. drive-strength = <4>;

Regards,
Angelo

> +		};
> +	};
>   };
>   
>   &spi2 {
> @@ -200,6 +216,14 @@ &usb_phy {
>   	status = "okay";
>   };
>   
> +&wifi {
> +	nvmem-cells = <&wifi_factory_calibration>;
> +	nvmem-cell-names = "eeprom";
> +	pinctrl-names = "dbdc";
> +	pinctrl-0 = <&wifi_dbdc_pins>;
> +	status = "okay";
> +};
> +
>   &xhci {
>   	phys = <&u2port0 PHY_TYPE_USB2>;
>   	vusb33-supply = <&reg_3p3v>;
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> index eb2effb3c1ed2..17dd13d4c0015 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> @@ -490,7 +490,7 @@ wo_ccif0: syscon@...a5000 {
>   			interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>;
>   		};
>   
> -		wifi@...00000 {
> +		wifi: wifi@...00000 {
>   			compatible = "mediatek,mt7981-wmac";
>   			reg = <0 0x18000000 0 0x1000000>,
>   			      <0 0x10003000 0 0x1000>,
>