netdev - Re: [PATCH net] selftests: netdevsim: Fix ethtool-features.sh fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ea387c7-cd15-44cc-8789-af3fbe0460a3@huawei.com>
Date: Mon, 3 Nov 2025 16:58:42 +0800
From: Wang Liang <wangliang74@...wei.com>
To: Sabrina Dubroca <sd@...asysnail.net>
CC: <kuba@...nel.org>, <andrew@...n.ch>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <shuah@...nel.org>,
	<horms@...nel.org>, <netdev@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<yuehaibing@...wei.com>, <zhangchangzhong@...wei.com>
Subject: Re: [PATCH net] selftests: netdevsim: Fix ethtool-features.sh fail


在 2025/10/31 7:13, Sabrina Dubroca 写道:
> 2025-10-30, 11:22:03 +0800, Wang Liang wrote:
>> This patch adds executable permission to script 'ethtool-features.sh', and
>> check 'ethtool --json -k' support.
> Those are two separate things, probably should be two separate patches.


Ok, I will extract the executable permission change to a new patch.

>
> [...]
>> @@ -7,6 +7,11 @@ NSIM_NETDEV=$(make_netdev)
>>   
>>   set -o pipefail
>>   
>> +if ! ethtool --json -k $NSIM_NETDEV > /dev/null 2>&1; then
> I guess it's improving the situation, but I've got a system with an
> ethtool that accepts the --json argument, but silently ignores it for
>   -k (ie `ethtool --json -k $DEV` succeeds but doesn't produce a json
> output), which will still cause the test to fail later.


That is indeed a bit strange.

I'm not sure the best way to handle this situation now. Maybe update ethtool
instead of checking the output is not a bad method.