netdev - Re: [PATCH net-next] iavf: clarify VLAN add/delete log messages and lower log level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05a823d2-231d-47de-89fa-9648e47cbfa5@intel.com>
Date: Mon, 3 Nov 2025 10:27:15 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
CC: <alok.a.tiwarilinux@...il.com>, <aleksander.lobakin@...el.com>,
	<anthony.l.nguyen@...el.com>, <andrew+netdev@...n.ch>, <kuba@...nel.org>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<horms@...nel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] iavf: clarify VLAN add/delete log messages and
 lower log level

On 11/3/25 10:03, Alok Tiwari wrote:
> The current dev_warn messages for too many VLAN changes are confusing
> and one place incorrectly reference "add" instead of "delete" VLANs
> due to copy-paste errors.
> 
> - Use dev_info instead of dev_warn to lower the log level.
> - Rephrase the message to: "Too many VLAN [add|delete] changes requested,
>    splitting into multiple messages to PF".
> 
> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

thank you!
just two minor nits, but the messages are good already, so:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

> ---
> https://lore.kernel.org/all/47f8c95c-bac4-471f-8e58-9155c6e58cb5@intel.com/
> ---
>   drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> index 34a422a4a29c..3593c0b45cf7 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> @@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
>   
>   		len = virtchnl_struct_size(vvfl, vlan_id, count);
>   		if (len > IAVF_MAX_AQ_BUF_SIZE) {
> -			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
> +			dev_info(&adapter->pdev->dev, "Too many VLAN add changes requested,\n"
> +				"splitting into multiple messages to PF\n");

perhaps it is too much bikeshedding for such a change, sorry, but
I would rather remove the newline in the middle

nit: another thing that I would consider is to differentiate the 
messages (v1/v2 or A/B, or whatever) for different protocol versions

>   			while (len > IAVF_MAX_AQ_BUF_SIZE)
>   				len = virtchnl_struct_size(vvfl, vlan_id,
>   							   --count);
> @@ -838,7 +839,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
>   
>   		len = virtchnl_struct_size(vvfl_v2, filters, count);
>   		if (len > IAVF_MAX_AQ_BUF_SIZE) {
> -			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
> +			dev_info(&adapter->pdev->dev, "Too many VLAN add changes requested,\n"
> +				"splitting into multiple messages to PF\n");
>   			while (len > IAVF_MAX_AQ_BUF_SIZE)
>   				len = virtchnl_struct_size(vvfl_v2, filters,
>   							   --count);
> @@ -941,7 +943,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
>   
>   		len = virtchnl_struct_size(vvfl, vlan_id, count);
>   		if (len > IAVF_MAX_AQ_BUF_SIZE) {
> -			dev_warn(&adapter->pdev->dev, "Too many delete VLAN changes in one request\n");
> +			dev_info(&adapter->pdev->dev, "Too many VLAN delete changes requested,\n"
> +				"splitting into multiple messages to PF\n");
>   			while (len > IAVF_MAX_AQ_BUF_SIZE)
>   				len = virtchnl_struct_size(vvfl, vlan_id,
>   							   --count);
> @@ -987,7 +990,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
>   
>   		len = virtchnl_struct_size(vvfl_v2, filters, count);
>   		if (len > IAVF_MAX_AQ_BUF_SIZE) {
> -			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
> +			dev_info(&adapter->pdev->dev, "Too many VLAN delete changes requested,\n"
> +				"splitting into multiple messages to PF\n");
>   			while (len > IAVF_MAX_AQ_BUF_SIZE)
>   				len = virtchnl_struct_size(vvfl_v2, filters,
>   							   --count);