netdev - 回覆: [PATCH net-next v3 0/4] Add AST2600 RGMII delay into ftgmac100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB51347DC658F062BD79BE18A59DC4A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Tue, 4 Nov 2025 08:35:37 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Po-Yu Chuang <ratbert@...aday-tech.com>, Joel Stanley
	<joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "taoren@...a.com" <taoren@...a.com>
Subject:
 回覆: [PATCH net-next v3 0/4] Add AST2600 RGMII delay into ftgmac100

Hi Krzysztof

> > ---
> > v3:
> >  - Add new item on compatible property for new compatible strings
> >  - Remove the new compatible and scu handle of MAC from aspeed-g6.dtsi
> >  - Add new compatible and scu handle to MAC node in
> >    aspeed-ast2600-evb.dts
> >  - Change all phy-mode of MACs to "rgmii-id"
> >  - Keep "aspeed,ast2600-mac" compatible in ftgmac100.c and configure the
> >    rgmii delay with "aspeed,ast2600-mac01" and "aspeed,ast2600-mac23"
> > v2:
> >  - added new compatible strings for MAC0/1 and MAC2/3
> >  - updated device tree bindings to restrict phy-mode and delay
> > properties
> >  - refactored driver code to handle rgmii delay configuration
> 
> That's b4 managed change, so where are the lorelinks? Why are you removing
> them?
> 
> Since you decided to drop them making it difficult for me to find previous
> revisions, I will not bother to look at background of this patchset to understand
> why you did that way and just NAK the binding.
> 
> Next time, make it easy for reviewers, not intentionally difficult.
> 

Thanks for pointing that out.
The missing lore links were due to my attempt to use b4 for sending this version, 
and some information was unintentionally dropped.
Starting from the next revision, I’ll make sure to include all the proper lore links 
and metadata generated by b4 send.

Sorry about the missing lore links in this version. and thank you for the review.

Thanks,
Jacky