netdev - Re: [PATCH AUTOSEL 6.17-6.1] smsc911x: add second read of EEPROM mac when possible corruption seen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQoFtH9_z5Q4cD9c@laps>
Date: Tue, 4 Nov 2025 08:55:00 -0500
From: Sasha Levin <sashal@...nel.org>
To: Colin Foster <colin.foster@...advantage.com>
Cc: patches@...ts.linux.dev, stable@...r.kernel.org,
	Jakub Kicinski <kuba@...nel.org>, steve.glendinning@...well.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.17-6.1] smsc911x: add second read of EEPROM mac
 when possible corruption seen

On Tue, Oct 28, 2025 at 07:53:31AM -0500, Colin Foster wrote:
>Hi Sasha,
>
>On Sat, Oct 25, 2025 at 11:55:34AM -0400, Sasha Levin wrote:
>> From: Colin Foster <colin.foster@...advantage.com>
>>
>> [ Upstream commit 69777753a8919b0b8313c856e707e1d1fe5ced85 ]
>>
>> When the EEPROM MAC is read by way of ADDRH, it can return all 0s the
>> first time. Subsequent reads succeed.
>>
>> This is fully reproduceable on the Phytec PCM049 SOM.
>>
>> Re-read the ADDRH when this behaviour is observed, in an attempt to
>> correctly apply the EEPROM MAC address.
>>
>> Signed-off-by: Colin Foster <colin.foster@...advantage.com>
>> Link: https://patch.msgid.link/20250903132610.966787-1-colin.foster@in-advantage.com
>> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>>
>> LLM Generated explanations, may be completely bogus:
>>
>> YES
>>
>
>I agree this should be back-ported. Do you need any action from me?

Nope! Thanks for the review.

-- 
Thanks,
Sasha