netdev - Re: [PATCH] firmware_loader: make RUST_FW_LOADER_ABSTRACTIONS select FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DDZZRCRHBLVI.MGWBUONLZ94K@kernel.org>
Date: Tue, 04 Nov 2025 15:48:10 +0100
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: "Alexandre Courbot" <acourbot@...dia.com>, "Luis Chamberlain"
 <mcgrof@...nel.org>, "Russ Weight" <russ.weight@...ux.dev>, "Rafael J.
 Wysocki" <rafael@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>, "David
 Airlie" <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Andrew
 Lunn" <andrew@...n.ch>, "Heiner Kallweit" <hkallweit1@...il.com>, "Russell
 King" <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>, "Miguel Ojeda" <ojeda@...nel.org>, "Alex
 Gaynor" <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary
 Guo" <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Trevor Gross" <tmgross@...ch.edu>,
 <linux-kernel@...r.kernel.org>, <nouveau@...ts.freedesktop.org>,
 <dri-devel@...ts.freedesktop.org>, <netdev@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH] firmware_loader: make RUST_FW_LOADER_ABSTRACTIONS
 select FW_LOADER

On Tue Nov 4, 2025 at 3:35 PM CET, Greg Kroah-Hartman wrote:
> On Tue, Nov 04, 2025 at 11:04:49PM +0900, Alexandre Courbot wrote:
>> diff --git a/drivers/base/firmware_loader/Kconfig b/drivers/base/firmware_loader/Kconfig
>> index 752b9a9bea03..15eff8a4b505 100644
>> --- a/drivers/base/firmware_loader/Kconfig
>> +++ b/drivers/base/firmware_loader/Kconfig
>> @@ -38,7 +38,7 @@ config FW_LOADER_DEBUG
>>  config RUST_FW_LOADER_ABSTRACTIONS
>>  	bool "Rust Firmware Loader abstractions"
>>  	depends on RUST
>> -	depends on FW_LOADER=y
>> +	select FW_LOADER
>
> Please no, select should almost never be used, it causes hard-to-debug
> issues.

I agree that select can be very annoying at times, but in this case it seems to
be the correct thing to do?

For instance for something like:

	config MY_DRIVER
		depends on PCI
		depends on DRM
		select AUXILIARY_BUS
		select FW_LOADER

In this case MY_DRIVER is only available if PCI and DRM is enabled, which makes
sense, there is no reason to show users PCI and DRM drivers if both are
disabled.

However, for things like AUXILIARY_BUS and FW_LOADER, I'd argue that they are
implementation details of the driver and should be selected if the driver is
selected.

Otherwise, wouldn't we expect users to know implementation details of drivers
before being able to select them?