netdev - Re: [RESEND PATCH net-next v2 2/4] net/ipv6: create ipv6_fl_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKD1Yr2maTnjEjYYFn9MNG-R+Mx7jw8wcxfowbAk+h=LCZE1pA@mail.gmail.com>
Date: Tue, 4 Nov 2025 12:51:26 -0500
From: Lorenzo Colitti <lorenzo@...gle.com>
To: David Lamparter <equinox@...c24.net>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, 
	Patrick Rohr <prohr@...gle.com>
Subject: Re: [RESEND PATCH net-next v2 2/4] net/ipv6: create ipv6_fl_get_saddr

On Tue, Nov 4, 2025 at 9:49 AM David Lamparter <equinox@...c24.net> wrote:
> This adds passing the relevant flow information as well as selected
> nexthop into the source address selection code, to allow the RFC6724
> rule 5.5 code to look at its details.
>
> [...]
>  struct ipv6_saddr_dst {
> -       const struct in6_addr *addr;
> +       const struct flowi6 *fl6;

Do you need an entire flowi6? In this patch I see that you only use
saddr and daddr. But flowi6 has lots of information in it that
potentially duplicates other inputs to this function - for example,
the ifindex could also be in flowi6->oif. Should you pass in a
different object than flowi6? Or should, for example, flowi6->oif be
updated with dst->ifindex?

Similarly, do you need a sk? I don't think you use it in this patch.
Is it used in future patches?