netdev - Re: [PATCH net-next v2 2/2] net/mlx5: implement swp_l4_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251104112214.7f60b252@kernel.org>
Date: Tue, 4 Nov 2025 11:22:14 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Daniel Zahka <daniel.zahka@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jonathan Corbet
 <corbet@....net>, Srujana Challa <schalla@...vell.com>, Bharat Bhushan
 <bbhushan2@...vell.com>, Herbert Xu <herbert@...dor.apana.org.au>, Brett
 Creeley <brett.creeley@....com>, Andrew Lunn <andrew+netdev@...n.ch>,
 Michael Chan <michael.chan@...adcom.com>, Pavan Chebbi
 <pavan.chebbi@...adcom.com>, Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>, Sunil Goutham
 <sgoutham@...vell.com>, Linu Cherian <lcherian@...vell.com>, Geetha
 sowjanya <gakula@...vell.com>, Jerin Jacob <jerinj@...vell.com>, hariprasad
 <hkelam@...vell.com>, Subbaraya Sundeep <sbhatta@...vell.com>, Tariq Toukan
 <tariqt@...dia.com>, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky
 <leon@...nel.org>, Mark Bloch <mbloch@...dia.com>, Ido Schimmel
 <idosch@...dia.com>, Petr Machata <petrm@...dia.com>, Manish Chopra
 <manishc@...vell.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>, Siddharth Vadapalli
 <s-vadapalli@...com>, Roger Quadros <rogerq@...nel.org>, Loic Poulain
 <loic.poulain@....qualcomm.com>, Sergey Ryazanov <ryazanov.s.a@...il.com>,
 Johannes Berg <johannes@...solutions.net>, Vladimir Oltean
 <olteanv@...il.com>, Michal Swiatkowski
 <michal.swiatkowski@...ux.intel.com>, Aleksandr Loktionov
 <aleksandr.loktionov@...el.com>, Dave Ertman <david.m.ertman@...el.com>,
 Vlad Dumitrescu <vdumitrescu@...dia.com>, "Russell King (Oracle)"
 <rmk+kernel@...linux.org.uk>, Alexander Sverdlin
 <alexander.sverdlin@...il.com>, Lorenzo Bianconi <lorenzo@...nel.org>,
 netdev@...r.kernel.org, linux-doc@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, linux-rdma@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net/mlx5: implement swp_l4_csum_mode
 via devlink params

On Tue, 4 Nov 2025 11:14:03 +0100 Jiri Pirko wrote:
> >@@ -548,6 +703,12 @@ static const struct devlink_param mlx5_nv_param_devlink_params[] = {
> > 			     mlx5_nv_param_devlink_cqe_compress_get,
> > 			     mlx5_nv_param_devlink_cqe_compress_set,
> > 			     mlx5_nv_param_devlink_cqe_compress_validate),
> >+	DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_SWP_L4_CSUM_MODE,
> >+			     "swp_l4_csum_mode", DEVLINK_PARAM_TYPE_STRING,  
> 
> I still think that even unlikely this will be implemented in other
> driver, it is generic param. Could you please treat it as such?

We need a clearer definition of what this does then.

Is it basically disabling silicon validation of L4 checksum and allows
for the FW to compute the L4 checksum? Which may negatively impact
performance? (hence disabled by default?)