netdev - Re: [RESEND PATCH net-next v2 2/4] net/ipv6: create ipv6_fl_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQptO3iWSdZkdfAs@eidolon.nox.tf>
Date: Tue, 4 Nov 2025 22:16:43 +0100
From: David Lamparter <equinox@...c24.net>
To: David Lamparter <equinox@...c24.net>
Cc: Lorenzo Colitti <lorenzo@...gle.com>, netdev@...r.kernel.org,
	Jakub Kicinski <kuba@...nel.org>, Patrick Rohr <prohr@...gle.com>
Subject: Re: [RESEND PATCH net-next v2 2/4] net/ipv6: create ipv6_fl_get_saddr

On Tue, Nov 04, 2025 at 09:47:18PM +0100, David Lamparter wrote:
> On Tue, Nov 04, 2025 at 12:51:26PM -0500, Lorenzo Colitti wrote:
> > On Tue, Nov 4, 2025 at 9:49 AM David Lamparter <equinox@...c24.net> wrote:
> > > This adds passing the relevant flow information as well as selected
> > > nexthop into the source address selection code, to allow the RFC6724
> > > rule 5.5 code to look at its details.
> > >
> > > [...]
> > >  struct ipv6_saddr_dst {
> > > -       const struct in6_addr *addr;
> > > +       const struct flowi6 *fl6;
> > 
> > Do you need an entire flowi6? In this patch I see that you only use
> > saddr and daddr.
> [quote reordered below]
> > Similarly, do you need a sk? I don't think you use it in this patch.
> > Is it used in future patches?
> 
> The answer is the same for both fields: the RFC6724 code (which I
> haven't posted yet and really should)

I've thrown up this (unfinished) code at
https://github.com/eqvinox/linux/commits/rule-5-5-HEAD/

This is NOT a request for reviews of those changes; I'm still working
on things.