netdev - Re: [PATCH] [PATCH] usb: rtl8150: Initialize buffers to fix KMSAN uninit-value in rtl8150

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025110531-replace-grass-3c41@gregkh>
Date: Wed, 5 Nov 2025 07:19:02 +0900
From: Greg KH <gregkh@...uxfoundation.org>
To: Dharanitharan R <dharanitharan725@...il.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	syzbot+b4d5d8faea6996fd55e3@...kaller.appspotmail.com,
	syzbot+b4d5d8faea6996fd@...kaller.appspotmail.com
Subject: Re: [PATCH] [PATCH] usb: rtl8150: Initialize buffers to fix KMSAN
 uninit-value in rtl8150_open

On Tue, Nov 04, 2025 at 04:48:37PM +0000, Dharanitharan R wrote:
> KMSAN reported an uninitialized value use in rtl8150_open().
> Initialize rx_skb->data and intr_buff before submitting URBs to
> ensure memory is in a defined state.
> 
> Reported-by: syzbot+b4d5d8faea6996fd@...kaller.appspotmail.com
> Signed-off-by: Dharanitharan R <dharanitharan725@...il.com>
> ---
>  drivers/net/usb/rtl8150.c | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index 278e6cb6f4d9..f1a868f0032e 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -719,14 +719,15 @@ static netdev_tx_t rtl8150_start_xmit(struct sk_buff *skb,
>  
>  static void set_carrier(struct net_device *netdev)
>  {
> -	rtl8150_t *dev = netdev_priv(netdev);
> -	short tmp;
> +    rtl8150_t *dev = netdev_priv(netdev);
> +    short tmp;

Always run checkpatch on your changes so you don't get grumpy
maintainers asking why you didn't run checkpatch on your change :)

Please fix and send a v2.

thanks,

greg k-h