netdev - [PATCH net-next v2] ptp: Return -EINVAL on ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251104225915.2040080-1-thostet@google.com>
Date: Tue,  4 Nov 2025 14:59:15 -0800
From: Tim Hostetler <thostet@...gle.com>
To: netdev@...r.kernel.org
Cc: richardcochran@...il.com, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	linux-kernel@...r.kernel.org, Tim Hostetler <thostet@...gle.com>, 
	Kuniyuki Iwashima <kuniyu@...gle.com>, Harshitha Ramamurthy <hramamurthy@...gle.com>, 
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Subject: [PATCH net-next v2] ptp: Return -EINVAL on ptp_clock_register if
 required ops are NULL

ptp_clock should never be registered unless it stubs one of gettimex64()
or gettime64() and settime64(). WARN_ON_ONCE and error out if either set
of function pointers is null.

For consistency, n_alarm validation is also folded into the
WARN_ON_ONCE.

Suggested-by: Kuniyuki Iwashima <kuniyu@...gle.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>
Reviewed-by: Harshitha Ramamurthy <hramamurthy@...gle.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Signed-off-by: Tim Hostetler <thostet@...gle.com>
---
Changes in v2:
  * Switch to net-next tree (Jakub Kicinski, Vadim Fedorenko)
  * Fold in n_alarm check into WARN_ON_ONCE (Jakub Kicinski)
---
 drivers/ptp/ptp_clock.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
index ef020599b771..b0e167c0b3eb 100644
--- a/drivers/ptp/ptp_clock.c
+++ b/drivers/ptp/ptp_clock.c
@@ -322,7 +322,9 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
 	char debugfsname[16];
 	size_t size;
 
-	if (info->n_alarm > PTP_MAX_ALARMS)
+	if (WARN_ON_ONCE(info->n_alarm > PTP_MAX_ALARMS ||
+			 (!info->gettimex64 && !info->gettime64) ||
+			 !info->settime64))
 		return ERR_PTR(-EINVAL);
 
 	/* Initialize a clock structure. */
-- 
2.51.2.1026.g39e6a42477-goog