netdev - Re: [PATCH v3 1/1] net: core: prevent NULL deref in generic_hwtstamp_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251103171557.3c5123cc@kernel.org>
Date: Mon, 3 Nov 2025 17:15:57 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jiaming Zhang <r772577952@...il.com>
Cc: kory.maincent@...tlin.com, davem@...emloft.net, edumazet@...gle.com,
 horms@...nel.org, kuniyu@...gle.com, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, pabeni@...hat.com, sdf@...ichev.me,
 syzkaller@...glegroups.com, vladimir.oltean@....com
Subject: Re: [PATCH v3 1/1] net: core: prevent NULL deref in
 generic_hwtstamp_ioctl_lower()

On Thu, 30 Oct 2025 12:49:47 +0000 Jiaming Zhang wrote:
> +	/* Netlink path with unconverted lower driver */
> +	if (!kernel_cfg->ifr)
> +		return -EOPNOTSUPP;
> +
>  	/* Legacy path: unconverted lower driver */
>  	return generic_hwtstamp_ioctl_lower(dev, SIOCGHWTSTAMP, kernel_cfg);
>  }
> @@ -498,6 +502,10 @@ int generic_hwtstamp_set_lower(struct net_device *dev,
>  		return err;
>  	}
>  
> +	/* Netlink path with unconverted lower driver */
> +	if (!kernel_cfg->ifr)
> +		return -EOPNOTSUPP;
> +
>  	/* Legacy path: unconverted lower driver */
>  	return generic_hwtstamp_ioctl_lower(dev, SIOCSHWTSTAMP, kernel_cfg);

Sorry but nit:

instead of adding this to both callers you can add the check in
generic_hwtstamp_ioctl_lower().
-- 
pw-bot: cr