netdev - 回覆: [PATCH net-next v3 3/4] ARM: dts: aspeed: ast2600-evb: Configure RGMII delay for MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB513451111EEC8147900B33B79DC4A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Tue, 4 Nov 2025 04:54:47 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Po-Yu Chuang <ratbert@...aday-tech.com>, Joel Stanley
	<joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "taoren@...a.com" <taoren@...a.com>
Subject:
 回覆: [PATCH net-next v3 3/4] ARM: dts: aspeed: ast2600-evb: Configure RGMII delay for MAC

Hi Andrew,

> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts
> > b/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts
> > index de83c0eb1d6e..a65568e637bd 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts
> > @@ -121,44 +121,64 @@ ethphy3: ethernet-phy@0 {  };
> >
> >  &mac0 {
> > +	compatible = "aspeed,ast2600-mac01", "aspeed,ast2600-mac",
> > +"faraday,ftgmac100";
> 
> Is it really compatible to aspeed,ast2600-mac? If a driver binds to that, not
> aspeed,ast2600-mac01, doesn't that imply the bootloader delays are still in use,
> so phy-mode will be wrong?
> 
> I think you should only list aspeed,ast2600-mac01. If somebody uses this DT
> blob on an old kernel, then you won't get an ethernet interface, rather than a
> not working ethernet interface, which is probably preferable.
> 

Thanks for pointing that out.
Agreed. I'll update the patch to only use "aspeed,ast2600-mac01" as the compatible 
String like below, so that only the new driver version binds.
I'll also update the dt-binding yaml.

&mac0 {
	compatible = "aspeed,ast2600-mac01", "faraday,ftgmac100";
	...
};

Thanks,
Jacky