netdev - RE: [PATCH iwl-next 1/9] ice: initialize ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB898681EE5525D6B02D8FAD15E5C4A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Tue, 4 Nov 2025 07:22:21 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH iwl-next 1/9] ice: initialize ring_stats->syncp



> -----Original Message-----
> From: Keller, Jacob E <jacob.e.keller@...el.com>
> Sent: Tuesday, November 4, 2025 2:07 AM
> To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Lobakin,
> Aleksander <aleksander.lobakin@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Keller,
> Jacob E <jacob.e.keller@...el.com>
> Subject: [PATCH iwl-next 1/9] ice: initialize ring_stats->syncp
> 
> The u64_stats_sync structure is empty on 64-bit systems. However, on
> 32-bit systems it contains a seqcount_t which needs to be initialized.
> While the memory is zero-initialized, a lack of u64_stats_init means
> that lockdep won't get initialized properly. Fix this by adding
> u64_stats_init() calls to the rings just after allocation.
> 
> Fixes: 2b245cb29421 ("ice: Implement transmit and NAPI support")
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c
> b/drivers/net/ethernet/intel/ice/ice_lib.c
> index bac481e8140d..e7265e877703 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
> @@ -398,7 +398,10 @@ static int ice_vsi_alloc_ring_stats(struct
> ice_vsi *vsi)
>  			if (!ring_stats)
>  				goto err_out;
> 
> +			u64_stats_init(&ring_stats->syncp);
> +
>  			WRITE_ONCE(tx_ring_stats[i], ring_stats);
> +
>  		}
> 
>  		ring->ring_stats = ring_stats;
> @@ -417,6 +420,8 @@ static int ice_vsi_alloc_ring_stats(struct ice_vsi
> *vsi)
>  			if (!ring_stats)
>  				goto err_out;
> 
> +			u64_stats_init(&ring_stats->syncp);
> +
>  			WRITE_ONCE(rx_ring_stats[i], ring_stats);
>  		}
> 
> 
> --
> 2.51.0.rc1.197.g6d975e95c9d7

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>