netdev - RE: [PATCH iwl-next 0/9] ice: properly use u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986AB2DBE26AD6A7E3362A2E5C4A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Tue, 4 Nov 2025 07:27:17 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH iwl-next 0/9] ice: properly use u64_stats API for all ring
 stats



> -----Original Message-----
> From: Keller, Jacob E <jacob.e.keller@...el.com>
> Sent: Tuesday, November 4, 2025 2:07 AM
> To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Lobakin,
> Aleksander <aleksander.lobakin@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Keller,
> Jacob E <jacob.e.keller@...el.com>
> Subject: [PATCH iwl-next 0/9] ice: properly use u64_stats API for all
> ring stats
> 
> The ice driver has multiple u64 values stored in the ring structures
> for each queue used for statistics. These are accumulated in
> ice_update_vsi_stats(). The packet and byte values are read using the
> u64_stats API from <linux/u64_stats_sync.h>.
> 
> Several non-standard counters are also accumulated in the same
> function, but do not use the u64_stats API. This could result in
> load/store tears on 32-bit architectures. Further, since commit
> 316580b69d0a ("u64_stats:
> provide u64_stats_t type"), the u64 stats API has had u64_stats_t and
> access functions which convert to local64_t on 64-bit architectures.
> 
> The ice driver doesn't use u64_stats_t and these access functions.
> Thus even on 64-bit architectures it could read inconsistent values.
> This series refactors the ice driver to use the updated API. Along the
> way I noticed several other issues and inconsistencies which I have
> cleaned up, summarized below.
> 
> *) The driver never called u64_stats_init, leaving the syncp
> improperly
>    initialized. Since the field is part of a kzalloc block, this only
>    impacts 32-bit systens with CONFIG_LOCKDEP enabled.
> 
“systens” → “systems”

Best regards, Alex

...

> --
> Jacob Keller <jacob.e.keller@...el.com>