netdev - Re: [PATCH net-next 2/3] netlink: specs: update rt-rule src/dst attribute types to support IPv4 addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251104164804.540a9b8d@kernel.org>
Date: Tue, 4 Nov 2025 16:48:04 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Donald Hunter <donald.hunter@...il.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jan Stancek
 <jstancek@...hat.com>, "Matthieu Baerts (NGI0)" <matttbe@...nel.org>,
 Asbjørn Sloth Tønnesen <ast@...erby.net>,
 Stanislav Fomichev <sdf@...ichev.me>, Shuah Khan <shuah@...nel.org>, Ido
 Schimmel <idosch@...dia.com>, Guillaume Nault <gnault@...hat.com>, Petr
 Machata <petrm@...dia.com>, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] netlink: specs: update rt-rule src/dst
 attribute types to support IPv4 addresses

On Tue, 4 Nov 2025 09:27:12 +0000 Hangbin Liu wrote:
> On Wed, Oct 29, 2025 at 04:37:42PM -0700, Jakub Kicinski wrote:
> > On Wed, 29 Oct 2025 08:22:44 +0000 Hangbin Liu wrote:  
> > >        -
> > >          name: dst
> > > -        type: u32
> > > +        type: binary
> > > +        display-hint: ipv4
> > >        -
> > >          name: src
> > > -        type: u32
> > > +        type: binary
> > > +        display-hint: ipv4  
> > 
> > This will be annoying For C / C++, and you didn't set the max len 
> > so I think we'll also have to malloc each time. Do we not support
> > display-hint for scalars?  
> 
> Hi Jakub,
> 
> I just realize that most of the address/src/dst in rt-addr/route are
> dual stack. The same with FRA_DST. We can't simply change binary to u32.
> So can we keep this u32 -> binary change?

Ah, should have looked at more context..
Yes, and in that case without the display-hint?