netdev - Re: [PATCH 1/2] vdpa/mlx5: update mlx_features with driver state check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <miwqc3uxmvvs5efvcqv7s4boajxjgko2ecqkyeqk62e4pwjexa@qi24ta7rftx6>
Date: Wed, 5 Nov 2025 10:02:54 +0000
From: Dragos Tatulea <dtatulea@...dia.com>
To: Cindy Lu <lulu@...hat.com>, mst@...hat.com, jasowang@...hat.com, 
	netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] vdpa/mlx5: update mlx_features with driver state
 check

Thanks for your patches!

On Wed, Nov 05, 2025 at 04:01:41PM +0800, Cindy Lu wrote:
> Add logic in mlx5_vdpa_set_attr() to ensure the VIRTIO_NET_F_MAC
> feature bit is properly set only when the device is not yet in
> the DRIVER_OK (running) state.
>
> This makes the MAC address visible in the output of:
> 
>  vdpa dev config show -jp
> 
> when the device is created without an initial MAC address.
>
So when the random MAC address is assigned it is not currently shown?
I don't fully understand the motivation.

> Signed-off-by: Cindy Lu <lulu@...hat.com>

> ---
>  drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index 82034efb74fc..e38aa3a335fc 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -4057,6 +4057,12 @@ static int mlx5_vdpa_set_attr(struct vdpa_mgmt_dev *v_mdev, struct vdpa_device *
>  	ndev = to_mlx5_vdpa_ndev(mvdev);
>  	mdev = mvdev->mdev;
>  	config = &ndev->config;

> +	if (!(ndev->mvdev.status & VIRTIO_CONFIG_S_DRIVER_OK)) {
> +		ndev->mvdev.mlx_features |= BIT_ULL(VIRTIO_NET_F_MAC);
> +	} else {
> +		mlx5_vdpa_warn(mvdev, "device running, skip updating MAC\n");
> +		return err;
The err is EOPNOTSUPP. Is this the right error?

> +	}
>
Why is this block not under the reslock?

Thanks,
Dragos