netdev - Re: [PATCH net] net: libwx: fix device bus LAN ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQs5UeY214tiuL3f@horms.kernel.org>
Date: Wed, 5 Nov 2025 11:47:29 +0000
From: Simon Horman <horms@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, 'Andrew Lunn' <andrew+netdev@...n.ch>,
	"'David S. Miller'" <davem@...emloft.net>,
	'Eric Dumazet' <edumazet@...gle.com>,
	'Jakub Kicinski' <kuba@...nel.org>,
	'Paolo Abeni' <pabeni@...hat.com>,
	'Mengyuan Lou' <mengyuanlou@...-swift.com>, stable@...r.kernel.org
Subject: Re: [PATCH net] net: libwx: fix device bus LAN ID

On Wed, Nov 05, 2025 at 06:05:29PM +0800, Jiawen Wu wrote:
> On Wed, Nov 5, 2025 5:59 PM, Simon Horman wrote:
> > On Tue, Nov 04, 2025 at 02:23:21PM +0800, Jiawen Wu wrote:
> > > The device bus LAN ID was obtained from PCI_FUNC(), but when a PF
> > > port is passthrough to a virtual machine, the function number may not
> > > match the actual port index on the device. This could cause the driver
> > > to perform operations such as LAN reset on the wrong port.
> > >
> > > Fix this by reading the LAN ID from port status register.
> > >
> > > Fixes: a34b3e6ed8fb ("net: txgbe: Store PCI info")
> > > Cc: stable@...r.kernel.org
> > > Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>
> > 
> > Hi Jiawen Wu,
> > 
> > I am wondering if these devises also support port swapping (maybe LAN
> > Function Select bit of FACTPS). And if so, does it need to be taken into
> > account here?
> 
> Does not support yet, thanks. :)

Thanks, in that case this patch looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>