netdev - Re: [PATCHv2 net-next 3/3] tools: ynl: add YNL test framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQuClqhaV-GiBxFZ@krikkit>
Date: Wed, 5 Nov 2025 18:00:06 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Donald Hunter <donald.hunter@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Jan Stancek <jstancek@...hat.com>,
	"Matthieu Baerts (NGI0)" <matttbe@...nel.org>,
	Asbjørn Sloth Tønnesen <ast@...erby.net>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Ido Schimmel <idosch@...dia.com>,
	Guillaume Nault <gnault@...hat.com>,
	Petr Machata <petrm@...dia.com>
Subject: Re: [PATCHv2 net-next 3/3] tools: ynl: add YNL test framework

2025-11-05, 08:28:41 +0000, Hangbin Liu wrote:
> +setup() {
> +	if ! modprobe netdevsim &>/dev/null; then
> +		echo "SKIP: all YNL CLI tests (netdevsim module not available)"

Can we maybe find a way to try to load the module and still run the
test if modprobe fails but netdevsim is built-in? I usually do my
testing in VMs with kernels where everything I need is built in, so I
don't do "make modules_install" and "modprobe netdevsim" fails even if
netdevsim is actually available (because it's built in).

For some modules it may be difficult, for netdevsim we could just run
modprobe (but ignore its return value) and check if
/sys/bus/netdevsim/new_device exists to decide if we need to skip the
tests?

Or do we only expect selftests/those new tests to run with the
standard net selftests config, and not with custom configs that also
provide all the required features?

-- 
Sabrina