netdev - Re: [PATCH net v2 2/2] net: bridge: fix MST static key usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQuDobziTNYqOxB4@shredder>
Date: Wed, 5 Nov 2025 19:04:33 +0200
From: Ido Schimmel <idosch@...dia.com>
To: Nikolay Aleksandrov <razor@...ckwall.org>
Cc: netdev@...r.kernel.org, tobias@...dekranz.com, kuba@...nel.org,
	davem@...emloft.net, bridge@...ts.linux.dev, pabeni@...hat.com,
	edumazet@...gle.com, horms@...nel.org, petrm@...dia.com
Subject: Re: [PATCH net v2 2/2] net: bridge: fix MST static key usage

On Wed, Nov 05, 2025 at 01:19:19PM +0200, Nikolay Aleksandrov wrote:
> As Ido pointed out, the static key usage in MST is buggy and should use
> inc/dec instead of enable/disable because we can have multiple bridges
> with MST enabled which means a single bridge can disable MST for all.
> Use static_branch_inc/dec to avoid that. When destroying a bridge decrement
> the key if MST was enabled.
> 
> Fixes: ec7328b59176 ("net: bridge: mst: Multiple Spanning Tree (MST) mode")
> Reported-by: Ido Schimmel <idosch@...dia.com>
> Closes: https://lore.kernel.org/netdev/20251104120313.1306566-1-razor@blackwall.org/T/#m6888d87658f94ed1725433940f4f4ebb00b5a68b
> Signed-off-by: Nikolay Aleksandrov <razor@...ckwall.org>

Reviewed-by: Ido Schimmel <idosch@...dia.com>