netdev - Re: [PATCH leds v2 00/10] Add support for offloading netdev trigger to HW + example implementation for Turris Omnia

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7be43544-20fe-4471-9fe4-1c8f82ad56ef@lunn.ch>
Date: Wed, 5 Nov 2025 19:35:30 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
Cc: Marek Behún <kabel@...nel.org>,
	linux-leds@...r.kernel.org, netdev@...r.kernel.org,
	Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
	Russell King <linux@...linux.org.uk>,
	Matthias Schiffer <matthias.schiffer@...tq-group.com>,
	Jacek Anaszewski <jacek.anaszewski@...il.com>,
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH leds v2 00/10] Add support for offloading netdev trigger
 to HW + example implementation for Turris Omnia

> # ls
> brightness  device  device_name  full_duplex  half_duplex  interval
> link  link_10  link_100  max_brightness  offloaded  power  rx  rx_err
> subsystem  trigger  tx  tx_err  uevent
> 
> As per HW manual [0] we have,
> 0: Combine enabled (link/activity, duplex/collision).
> 1: Disable combination (link only, duplex only).
> 
> # Combine DISABLED (link + duplex only)
> echo netdev > trigger
> echo 1 > link
> echo 1 > full_duplex  # or half_duplex
> echo 0 > rx
> echo 0 > tx
> 
> # Combine ENABLED (link + activity + duplex + collision)
> echo netdev > trigger
> echo 1 > link
> echo 1 > rx
> echo 1 > tx
> 
> So to Enable/Disable LEDx combine feature we just need to write as
> above. Is my understanding correct?

Yes. The PHY driver gets passed a bitmap of each features to
enable. Looking that those bits you need to decide on the 4 bit LED
mode value, and the combine bit. Or return -EOPNOTSUPP.

	Andrew