netdev - Re: [PATCH net] net: txgbe: remove wx_ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de2f5da5-05db-4bd7-90c3-c51558e50545@linux.dev>
Date: Wed, 5 Nov 2025 20:02:30 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Jiawen Wu <jiawenwu@...stnetic.com>, netdev@...r.kernel.org,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Richard Cochran <richardcochran@...il.com>, Simon Horman <horms@...nel.org>,
 Jacob Keller <jacob.e.keller@...el.com>
Cc: Mengyuan Lou <mengyuanlou@...-swift.com>, stable@...r.kernel.org
Subject: Re: [PATCH net] net: txgbe: remove wx_ptp_init() in device reset flow

On 05/11/2025 02:07, Jiawen Wu wrote:
> The functions txgbe_up() and txgbe_down() are called in pairs to reset
> hardware configurations. PTP stop function is not called in
> txgbe_down(), so there is no need to call PTP init function in
> txgbe_up().
> 

txgbe_reset() is called during txgbe_down(), and it calls
wx_ptp_reset(), which I believe is the reason for wx_ptp_init() call

> Fixes: 06e75161b9d4 ("net: wangxun: Add support for PTP clock")
> Cc: stable@...r.kernel.org
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>
> ---
>   drivers/net/ethernet/wangxun/txgbe/txgbe_main.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
> index daa761e48f9d..114d6f46139b 100644
> --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
> +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
> @@ -297,7 +297,6 @@ void txgbe_down(struct wx *wx)
>   void txgbe_up(struct wx *wx)
>   {
>   	wx_configure(wx);
> -	wx_ptp_init(wx);
>   	txgbe_up_complete(wx);
>   }
>