netdev - Re: [PATCH net-next v2 7/7] qede: convert to use ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251104174340.5d2d8741@kernel.org>
Date: Tue, 4 Nov 2025 17:43:40 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Manish Chopra <manishc@...vell.com>, Marco Crivellari
 <marco.crivellari@...e.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Sunil Goutham <sgoutham@...vell.com>, Richard
 Cochran <richardcochran@...il.com>, Russell King <linux@...linux.org.uk>,
 Vladimir Oltean <vladimir.oltean@....com>, Simon Horman <horms@...nel.org>,
 Jacob Keller <jacob.e.keller@...el.com>, Kory Maincent
 <kory.maincent@...tlin.com>, linux-arm-kernel@...ts.infradead.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 7/7] qede: convert to use ndo_hwtstamp
 callbacks

On Mon,  3 Nov 2025 15:09:52 +0000 Vadim Fedorenko wrote:
>  	ptp->hw_ts_ioctl_called = 1;
> -	ptp->tx_type = config.tx_type;
> -	ptp->rx_filter = config.rx_filter;
> +	ptp->tx_type = config->tx_type;
> +	ptp->rx_filter = config->rx_filter;
>  
>  	rc = qede_ptp_cfg_filters(edev);
> -	if (rc)
> +	if (rc) {
> +		NL_SET_ERR_MSG_MOD(extack,
> +				   "One-step timestamping is not supported");
>  		return rc;
> +	}
> +
> +	config->rx_filter = ptp->rx_filter;

Same story as the first patch.
I suppose these drives may predate the advanced tx config options.
Simple fix would be to move the tx_filter validation here instead.

I'll apply 2-6.