netdev - Re: [PATCH v2] usb: rtl8150: Initialize buffers to fix KMSAN uninit-value in rtl8150

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5ddc43a-5354-4951-8691-1f3887743e3d@intel.com>
Date: Wed, 5 Nov 2025 13:55:28 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Dharanitharan R <dharanitharan725@...il.com>, <netdev@...r.kernel.org>
CC: <linux-usb@...r.kernel.org>, <gregkh@...uxfoundation.org>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <syzbot+b4d5d8faea6996fd@...kaller.appspotmail.com>
Subject: Re: [PATCH v2] usb: rtl8150: Initialize buffers to fix KMSAN
 uninit-value in rtl8150_open



On 11/5/2025 11:47 AM, Dharanitharan R wrote:
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index f1a868f0032e..a7116d03c3d3 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -735,33 +735,30 @@ static int rtl8150_open(struct net_device *netdev)
>  	rtl8150_t *dev = netdev_priv(netdev);
>  	int res;
>  
> -	if (dev->rx_skb == NULL)
> -		dev->rx_skb = pull_skb(dev);
> -	if (!dev->rx_skb)
> -		return -ENOMEM;
> -

None of the changes in the diff make any sense, as you remove the only
place where rx_skb is initialized in the first place.

>  	set_registers(dev, IDR, 6, netdev->dev_addr);
>  
>  	/* Fix: initialize memory before using it (KMSAN uninit-value) */
>  	memset(dev->rx_skb->data, 0, RTL8150_MTU);
>  	memset(dev->intr_buff, 0, INTBUFSIZE);
>  

This isn't even in the current driver code, but its shown as part of the
diff context. Based on your commit description this is probably what
you're trying to insert? But its obviously not a properly formatted or
generated patch. It reeks of being generated by a bad LLM.

Please don't waste reviewers time with this kind of generated nonsense.


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)