netdev - Re: [PATCH net-next v2 1/4] net: altera-tse: Set platform drvdata before registering netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251104182035.29082775@kernel.org>
Date: Tue, 4 Nov 2025 18:20:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, davem@...emloft.net, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell King
 <linux@...linux.org.uk>, Simon Horman <horms@...nel.org>, Boon Khai Ng
 <boon.khai.ng@...era.com>, Alexis Lothoré
 <alexis.lothore@...tlin.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Andrew
 Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next v2 1/4] net: altera-tse: Set platform drvdata
 before registering netdev

On Mon,  3 Nov 2025 11:49:24 +0100 Maxime Chevallier wrote:
> We don't have to wait until netdev is registered before setting it as the
> pdev's drvdata. Move it at netdev alloc time.

FWIW sometimes the late setting of drvdata is done to make sure drvdata
is NULL if we error out but forget to set ret (so probe returns 0 even
tho it failed). But the error paths looks fine here so 🤷️