netdev - Re: [PATCH net-next 1/2] net: airoha: Add the capability to consume out-of-order DMA tx descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251104183028.7412aba6@kernel.org>
Date: Tue, 4 Nov 2025 18:30:28 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org, Xuegang Lu
 <xuegang.lu@...oha.com>
Subject: Re: [PATCH net-next 1/2] net: airoha: Add the capability to consume
 out-of-order DMA tx descriptors

On Mon, 03 Nov 2025 11:27:55 +0100 Lorenzo Bianconi wrote:
> +		__list_del_entry(&e->list);
> +		list_add_tail(&e->list, &tx_list);

list_move_tail()

> +		e->skb = i ? NULL : skb;
> +		e->dma_addr = addr;
> +		e->dma_len = len;
> +
> +		e = list_first_entry(&q->tx_list, struct airoha_queue_entry,
> +				     list);
> +		index = e - q->entry;
>  
>  		val = FIELD_PREP(QDMA_DESC_LEN_MASK, len);
>  		if (i < nr_frags - 1)

> @@ -2029,10 +2020,14 @@ static netdev_tx_t airoha_dev_xmit(struct sk_buff *skb,
>  	return NETDEV_TX_OK;
>  
>  error_unmap:
> -	for (i--; i >= 0; i--) {
> -		index = (q->head + i) % q->ndesc;
> -		dma_unmap_single(dev->dev.parent, q->entry[index].dma_addr,
> -				 q->entry[index].dma_len, DMA_TO_DEVICE);
> +	while (!list_empty(&tx_list)) {
> +		e = list_first_entry(&tx_list, struct airoha_queue_entry,
> +				     list);
> +		__list_del_entry(&e->list);
> +		dma_unmap_single(dev->dev.parent, e->dma_addr, e->dma_len,
> +				 DMA_TO_DEVICE);
> +		e->dma_addr = 0;
> +		list_add_tail(&e->list, &q->tx_list);

and here