netdev - Re: [PATCH net-next 1/2] net: phy: phy-c45: add OATC14 10BASE-T1S PHY cable diagnostic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62244da1-c644-4f89-b803-1a0c80d4bad8@microchip.com>
Date: Wed, 5 Nov 2025 04:37:43 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <andrew@...n.ch>
CC: <piergiorgio.beruto@...il.com>, <hkallweit1@...il.com>,
	<linux@...linux.org.uk>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: phy-c45: add OATC14 10BASE-T1S PHY
 cable diagnostic support

Hi Andrew,

Thanks for reviewing the patches.

On 04/11/25 9:16 pm, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> +/* Bus Short/Open Status:
>> + * 0 0 - no fault; everything is ok. (Default)
>> + * 0 1 - detected as an open or missing termination(s)
>> + * 1 0 - detected as a short or extra termination(s)
>> + * 1 1 - fault but fault type not detectable. More details can be available by
>> + *       vender specific register if supported.
>> + */
>> +enum oatc14_hdd_status {
>> +     OATC14_HDD_STATUS_CABLE_OK,
>> +     OATC14_HDD_STATUS_OPEN,
>> +     OATC14_HDD_STATUS_SHORT,
>> +     OATC14_HDD_STATUS_NOT_DETECTABLE,
> 
> You frequently see the first enum has an = 0 at the end. I don't know
> what the C standard allows the compiler to do, in terms of assigning
> values to these enums, but it won't work if it uses 42, 43, 44, 45.
> etc.
> 
> Otherwise, this looks O.K.
Ok, I’ll update it in the next version. I mistakenly added the wrong 
cover letter subject line, so I’ve already sent v2 to correct that. I’ll 
include this update in v3.

Best regards,
Parthiban V
> 
>          Andrew