netdev - Re: [External] : RE: [Intel-wired-lan] [PATCH net-next v2] iavf: clarify VLAN add/delete log messages and lower log level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e736c4a-bafa-44e6-9152-3a9de078ee4c@oracle.com>
Date: Wed, 5 Nov 2025 13:28:45 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>,
        "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
        "Lobakin, Aleksander" <aleksander.lobakin@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "horms@...nel.org"
 <horms@...nel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: "alok.a.tiwarilinux@...il.com" <alok.a.tiwarilinux@...il.com>
Subject: Re: [External] : RE: [Intel-wired-lan] [PATCH net-next v2] iavf:
 clarify VLAN add/delete log messages and lower log level



On 11/5/2025 12:59 PM, Loktionov, Aleksandr wrote:
>> The current dev_warn messages for too many VLAN changes are confusing
>> and one place incorrectly references "add" instead of "delete" VLANs
>> due to copy-paste errors.
>>
>> - Use dev_info instead of dev_warn to lower the log level.
>> - Rephrase the message to: "[vvfl|vvfl_v2] Too many VLAN [add|delete]
>>    requests; splitting into multiple messages to PF".
>>
>> Suggested-by: Przemek Kitszel<przemyslaw.kitszel@...el.com>
>> Signed-off-by: Alok Tiwari<alok.a.tiwari@...cle.com>
>> Reviewed-by: Przemek Kitszel<przemyslaw.kitszel@...el.com>
>> ---
>> v1 -> v2
>> remove "\n" b/w message
>> added vvfl and vvfl_v2 prefix
> Why vvfl and vvfl_v2 prefix? For me 'virtchnl:'  'virtchnl v2:'  looks more clear.
> Can you explain?

I am trying to follow the code path, as vvfl refers to the
virtchnl VLAN filter list. It’s just a way to segregate the logic
between the if/else conditions.
Either 'virtchnl:' or 'virtchnl v2:' also sound good to me.

Happy to go with whichever you prefer.

> 
> Thank you
> 
> ...


Thanks,
Alok