netdev - RE: [PATCH iwl-next v2 4/9] ice: move prev_pkt from ice_txq_stats to ice_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB89862D2AABBDC895B6AB4CD6E5C2A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Thu, 6 Nov 2025 14:56:56 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH iwl-next v2 4/9] ice: move prev_pkt from ice_txq_stats to
 ice_tx_ring



> -----Original Message-----
> From: Keller, Jacob E <jacob.e.keller@...el.com>
> Sent: Wednesday, November 5, 2025 10:07 PM
> To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Lobakin,
> Aleksander <aleksander.lobakin@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Keller,
> Jacob E <jacob.e.keller@...el.com>
> Subject: [PATCH iwl-next v2 4/9] ice: move prev_pkt from ice_txq_stats
> to ice_tx_ring
> 
> The prev_pkt field in ice_txq_stats is used by
> ice_check_for_hung_subtask as a way to detect potential Tx hangs due
> to missed interrupts.
> 
> The value is based on the packet count, but its an int and not really
> a "statistic". The value is signed so that we can use -1 as a "no work
> pending" value. A following change is going to refactor the stats to
> all use the u64_stat_t type and accessor functions. Leaving prev_pkt
> as the lone int feels a bit strange.
> 
> Instead, move it out of ice_txq_stats and place it in the ice_tx_ring.
> We have 8 bytes still available in the 3rd cacheline, so this move
> saves a small amount of memory. It also shouldn't impact the Tx path
> heavily since its only accessed during initialization and the hang
> subtask.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---

...
 
> --
> 2.51.0.rc1.197.g6d975e95c9d7


Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>