netdev - [PATCH v2 net-next 0/6] Disable CLKOUT on RTL8211F(D)(I)-VD-CG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251107110817.324389-1-vladimir.oltean@nxp.com>
Date: Fri,  7 Nov 2025 13:08:11 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: netdev@...r.kernel.org
Cc: Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Marek Vasut <marex@...x.de>,
	Wei Fang <wei.fang@....com>,
	Clark Wang <xiaoning.wang@....com>
Subject: [PATCH v2 net-next 0/6] Disable CLKOUT on RTL8211F(D)(I)-VD-CG

The Realtek RTL8211F(D)(I)-VD-CG is similar to other RTL8211F models in
that the CLKOUT signal can be turned off - a feature requested to reduce
EMI, and implemented via "realtek,clkout-disable" as documented in
Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml.

It is also dissimilar to said PHY models because it has no PHYCR2
register, and disabling CLKOUT is done through some other register.

The strategy adopted in this 6-patch series is to make the PHY driver
not think in terms of "priv->has_phycr2" and "priv->phycr2", but of more
high-level features ("priv->disable_clk_out") while maintaining behaviour.
Then, the logic is extended for the new PHY.

Very loosely based on previous work from Clark Wang, who took a
different approach, to pretend that the RTL8211FVD_CLKOUT_REG is
actually this PHY's PHYCR2.

v1 at:
https://lore.kernel.org/netdev/20251106111003.37023-1-vladimir.oltean@nxp.com/

Changes since v1:
- Apply Andrew's feedback regarding rtl8211f_config_clk_out() function
  naming
- Revisited the control flow that I was commenting on, and found an
  issue with RGMII delay handling which resulted in me declaring war on
  complex control flow schemes, and more specifically in patches 1/6 and
  6/6 which are new. Patch 1/6 is "probably" a bug fix, so it is at the
  top of the list in case the autosel bot wants to pick it up.

Vladimir Oltean (6):
  net: phy: realtek: create rtl8211f_config_rgmii_delay()
  net: phy: realtek: eliminate priv->phycr2 variable
  net: phy: realtek: eliminate has_phycr2 variable
  net: phy: realtek: allow CLKOUT to be disabled on RTL8211F(D)(I)-VD-CG
  net: phy: realtek: eliminate priv->phycr1 variable
  net: phy: realtek: create rtl8211f_config_phy_eee() helper

 drivers/net/phy/realtek/realtek_main.c | 156 ++++++++++++++++---------
 1 file changed, 101 insertions(+), 55 deletions(-)

-- 
2.34.1