netdev - Re: [PATCH v5 1/8] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <176251453854.1709481.17350672291824662534.robh@kernel.org>
Date: Fri, 07 Nov 2025 05:22:18 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: linux-stm32@...md-mailman.stormreply.com, 
 Eric Dumazet <edumazet@...gle.com>, Fabio Estevam <festevam@...il.com>, 
 David Wu <david.wu@...k-chips.com>, 
 Geert Uytterhoeven <geert+renesas@...der.be>, 
 Samin Guo <samin.guo@...rfivetech.com>, linux-amlogic@...ts.infradead.org, 
 netdev@...r.kernel.org, imx@...ts.linux.dev, 
 Maxime Coquelin <mcoquelin.stm32@...il.com>, 
 linux-renesas-soc@...r.kernel.org, Clark Wang <xiaoning.wang@....com>, 
 Jerome Brunet <jbrunet@...libre.com>, 
 Jernej Skrabec <jernej.skrabec@...il.com>, Guo Ren <guoren@...nel.org>, 
 Jose Abreu <joabreu@...opsys.com>, 
 Neil Armstrong <neil.armstrong@...aro.org>, 
 "G. Jaya Kumaran" <vineetha.g.jaya.kumaran@...el.com>, 
 Bjorn Andersson <andersson@...nel.org>, 
 Shuang Liang <liangshuang@...incomputing.com>, 
 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@...l.toshiba>, 
 Swathi K S <swathi.ks@...sung.com>, linux-arm-msm@...r.kernel.org, 
 Giuseppe Cavallaro <peppe.cavallaro@...com>, 
 linux-rockchip@...ts.infradead.org, Frank Li <Frank.Li@....com>, 
 Emil Renner Berthing <kernel@...il.dk>, 
 Shangjuan Wei <weishangjuan@...incomputing.com>, 
 Vinod Koul <vkoul@...nel.org>, Richard Cochran <richardcochran@...il.com>, 
 Alexandre Torgue <alexandre.torgue@...s.st.com>, 
 Maxime Ripard <mripard@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
 Jan Petrous <jan.petrous@....nxp.com>, 
 Drew Fustini <dfustini@...storrent.com>, s32@....com, 
 Conor Dooley <conor+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
 Samuel Holland <samuel@...lland.org>, Kevin Hilman <khilman@...libre.com>, 
 devicetree@...r.kernel.org, Chen-Yu Tsai <wens@...nel.org>, 
 linux-mips@...r.kernel.org, Konrad Dybcio <konradybcio@...nel.org>, 
 Matthew Gerlach <matthew.gerlach@...era.com>, 
 Zhi Li <lizhi2@...incomputing.com>, linux-sunxi@...ts.linux.dev, 
 Heiko Stuebner <heiko@...ech.de>, 
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, 
 Fu Wei <wefu@...hat.com>, Linux Team <linux-imx@....com>, 
 Christophe Roullier <christophe.roullier@...s.st.com>, 
 Pengutronix Kernel Team <kernel@...gutronix.de>, 
 Keguang Zhang <keguang.zhang@...il.com>, 
 Sascha Hauer <s.hauer@...gutronix.de>, 
 Romain Gantois <romain.gantois@...tlin.com>, 
 Magnus Damm <magnus.damm@...il.com>, Drew Fustini <fustini@...nel.org>, 
 Andrew Lunn <andrew+netdev@...n.ch>, 
 "David S. Miller" <davem@...emloft.net>, Shawn Guo <shawnguo@...nel.org>, 
 linux-kernel@...r.kernel.org, Inochi Amaoto <inochiama@...il.com>, 
 Jakub Kicinski <kuba@...nel.org>, sophgo@...ts.linux.dev, 
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
 Minda Chen <minda.chen@...rfivetech.com>, linux-riscv@...ts.infradead.org, 
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Chen Wang <unicorn_wang@...look.com>
Subject: Re: [PATCH v5 1/8] dt-bindings: net: qcom: document the ethqos
 device for SCMI-based systems


On Fri, 07 Nov 2025 11:29:51 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Describe the firmware-managed variant of the QCom DesignWare MAC. As the
> properties here differ a lot from the HLOS-managed variant, lets put it
> in a separate file. Since we need to update the maximum number of power
> domains, let's update existing bindings referencing the top-level
> snps,dwmac.yaml and limit their maxItems for power-domains to 1.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
>  .../bindings/net/allwinner,sun7i-a20-gmac.yaml     |  3 +
>  .../bindings/net/altr,socfpga-stmmac.yaml          |  3 +
>  .../bindings/net/amlogic,meson-dwmac.yaml          |  3 +
>  .../devicetree/bindings/net/eswin,eic7700-eth.yaml |  3 +
>  .../devicetree/bindings/net/intel,dwmac-plat.yaml  |  3 +
>  .../bindings/net/loongson,ls1b-gmac.yaml           |  3 +
>  .../bindings/net/loongson,ls1c-emac.yaml           |  3 +
>  .../devicetree/bindings/net/nxp,dwmac-imx.yaml     |  3 +
>  .../devicetree/bindings/net/nxp,lpc1850-dwmac.yaml |  3 +
>  .../devicetree/bindings/net/nxp,s32-dwmac.yaml     |  3 +
>  .../devicetree/bindings/net/qcom,ethqos.yaml       |  3 +
>  .../bindings/net/qcom,sa8255p-ethqos.yaml          | 98 ++++++++++++++++++++++
>  .../devicetree/bindings/net/renesas,rzn1-gmac.yaml |  3 +
>  .../bindings/net/renesas,rzv2h-gbeth.yaml          |  3 +
>  .../devicetree/bindings/net/rockchip-dwmac.yaml    |  3 +
>  .../devicetree/bindings/net/snps,dwmac.yaml        |  5 +-
>  .../bindings/net/sophgo,cv1800b-dwmac.yaml         |  3 +
>  .../bindings/net/sophgo,sg2044-dwmac.yaml          |  3 +
>  .../bindings/net/starfive,jh7110-dwmac.yaml        |  3 +
>  .../devicetree/bindings/net/stm32-dwmac.yaml       |  3 +
>  .../devicetree/bindings/net/tesla,fsd-ethqos.yaml  |  3 +
>  .../devicetree/bindings/net/thead,th1520-gmac.yaml |  3 +
>  .../bindings/net/toshiba,visconti-dwmac.yaml       |  3 +
>  MAINTAINERS                                        |  1 +
>  24 files changed, 166 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/qcom,sa8255p-ethqos.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
 	 $id: http://devicetree.org/schemas/net/qcom,ethqos-scmi.yaml
 	file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/qcom,sa8255p-ethqos.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251107-qcom-sa8255p-emac-v5-1-01d3e3aaf388@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.