netdev - Re: [PATCH v2 net-next 5/6] net: phy: realtek: eliminate priv->phycr1 variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ce87e6e-ee6e-4d3c-a5f0-73081999f5ea@lunn.ch>
Date: Fri, 7 Nov 2025 14:30:38 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Marek Vasut <marex@...x.de>, Wei Fang <wei.fang@....com>,
	Clark Wang <xiaoning.wang@....com>
Subject: Re: [PATCH v2 net-next 5/6] net: phy: realtek: eliminate
 priv->phycr1 variable

On Fri, Nov 07, 2025 at 01:08:16PM +0200, Vladimir Oltean wrote:
> Previous changes have replaced the machine-level priv->phycr2 with a
> high-level priv->disable_clk_out. This created a discrepancy with
> priv->phycr1 which is resolved here, for uniformity.
> 
> One advantage of this new implementation is that we don't read
> priv->phycr1 in rtl821x_probe() if we're never going to modify it.
> 
> We never test the positive return code from phy_modify_mmd_changed(), so
> we could just as well use phy_modify_mmd().
> 
> I took the ALDPS feature description from commit d90db36a9e74 ("net:
> phy: realtek: add dt property to enable ALDPS mode") and transformed it
> into a function comment - the feature is sufficiently non-obvious to
> deserve that.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew