netdev - [PATCH 4/4] net: qede: use scnprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <SYBPR01MB7881FF6A051A192E02112C94AFC3A@SYBPR01MB7881.ausprd01.prod.outlook.com>
Date: Fri,  7 Nov 2025 13:16:16 +0800
From: Junrui Luo <moonafterrain@...look.com>
To: linux-kernel@...r.kernel.org
Cc: pmladek@...e.com,
	rostedt@...dmis.org,
	andriy.shevchenko@...ux.intel.com,
	akpm@...ux-foundation.org,
	tiwai@...e.com,
	perex@...ex.cz,
	linux-sound@...r.kernel.org,
	mchehab@...nel.org,
	awalls@...metrocast.net,
	linux-media@...r.kernel.org,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com,
	netdev@...r.kernel.org,
	Junrui Luo <moonafterrain@...look.com>
Subject: [PATCH 4/4] net: qede: use scnprintf_append for version string

Replace snprintf(buf + strlen(buf), left_size, ...) with
scnprintf_append() for building the firmware version string. This
simplifies the code.

Signed-off-by: Junrui Luo <moonafterrain@...look.com>
---
 drivers/net/ethernet/qlogic/qede/qede_main.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index b5d744d2586f..6e85c3a4aaa9 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -1185,7 +1185,6 @@ static void qede_log_probe(struct qede_dev *edev)
 {
 	struct qed_dev_info *p_dev_info = &edev->dev_info.common;
 	u8 buf[QEDE_FW_VER_STR_SIZE];
-	size_t left_size;
 
 	snprintf(buf, QEDE_FW_VER_STR_SIZE,
 		 "Storm FW %d.%d.%d.%d, Management FW %d.%d.%d.%d",
@@ -1200,10 +1199,8 @@ static void qede_log_probe(struct qede_dev *edev)
 		 (p_dev_info->mfw_rev & QED_MFW_VERSION_0_MASK) >>
 		 QED_MFW_VERSION_0_OFFSET);
 
-	left_size = QEDE_FW_VER_STR_SIZE - strlen(buf);
-	if (p_dev_info->mbi_version && left_size)
-		snprintf(buf + strlen(buf), left_size,
-			 " [MBI %d.%d.%d]",
+	if (p_dev_info->mbi_version)
+		scnprintf_append(buf, QEDE_FW_VER_STR_SIZE, " [MBI %d.%d.%d]",
 			 (p_dev_info->mbi_version & QED_MBI_VERSION_2_MASK) >>
 			 QED_MBI_VERSION_2_OFFSET,
 			 (p_dev_info->mbi_version & QED_MBI_VERSION_1_MASK) >>
-- 
2.51.1.dirty