netdev - [PATCH iproute2] netshaper: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251108173540.21503-1-stephen@networkplumber.org>
Date: Sat,  8 Nov 2025 09:35:26 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: netdev@...r.kernel.org
Cc: Stephen Hemminger <stephen@...workplumber.org>,
	ernis@...ux.microsoft.com
Subject: [PATCH iproute2] netshaper: remove unused variable

Clang complains that the variable 'n' used for nlmsghdr is passed
uninitiailized. Remove it because it is never used.

Fixes: 6f7779ad4ef6 ("netshaper: Add netshaper command")
Cc: ernis@...ux.microsoft.com

Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
---
 netshaper/netshaper.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/netshaper/netshaper.c b/netshaper/netshaper.c
index edd964c1..47fb805e 100644
--- a/netshaper/netshaper.c
+++ b/netshaper/netshaper.c
@@ -98,7 +98,7 @@ static void print_netshaper_attrs(struct nlmsghdr *answer)
 	}
 }
 
-static int do_cmd(int argc, char **argv, struct nlmsghdr *n, int cmd)
+static int do_cmd(int argc, char **argv, int cmd)
 {
 	GENL_REQUEST(req, 1024, genl_family, 0, NET_SHAPER_FAMILY_VERSION, cmd,
 		     NLM_F_REQUEST | NLM_F_ACK);
@@ -220,7 +220,6 @@ static int do_cmd(int argc, char **argv, struct nlmsghdr *n, int cmd)
 
 int main(int argc, char **argv)
 {
-	struct nlmsghdr *n;
 	int color = default_color_opt();
 
 	while (argc > 1) {
@@ -258,11 +257,11 @@ int main(int argc, char **argv)
 		argv++;
 
 		if (strcmp(*argv, "set") == 0)
-			return do_cmd(argc - 1, argv + 1, n, NET_SHAPER_CMD_SET);
+			return do_cmd(argc - 1, argv + 1, NET_SHAPER_CMD_SET);
 		if (strcmp(*argv, "delete") == 0)
-			return do_cmd(argc - 1, argv + 1, n, NET_SHAPER_CMD_DELETE);
+			return do_cmd(argc - 1, argv + 1, NET_SHAPER_CMD_DELETE);
 		if (strcmp(*argv, "show") == 0)
-			return do_cmd(argc - 1, argv + 1, n, NET_SHAPER_CMD_GET);
+			return do_cmd(argc - 1, argv + 1, NET_SHAPER_CMD_GET);
 		if (strcmp(*argv, "help") == 0) {
 			usage();
 			return 0;
-- 
2.51.0