netdev - Re: [PATCH net] net: fec: correct rx_bytes statistic for the case SHIFT16 is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251107185937.0cbaf200@kernel.org>
Date: Fri, 7 Nov 2025 18:59:37 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Wei Fang <wei.fang@....com>
Cc: shenwei.wang@....com, xiaoning.wang@....com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 eric@...int.com, imx@...ts.linux.dev, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: fec: correct rx_bytes statistic for the case
 SHIFT16 is set

On Thu,  6 Nov 2025 10:14:21 +0800 Wei Fang wrote:
>  		ndev->stats.rx_bytes += pkt_len;
> +		if (fep->quirks & FEC_QUIRK_HAS_RACC)
> +			ndev->stats.rx_bytes -= 2;

Orthogonal to this patch, but why not:

	ndev->stats.rx_bytes += pkt_len - sub_len;

? Is this driver intentionally counting FCS as bytes?