netdev - Re: [PATCH net-next V2 3/3] net/mlx5: E-Switch, support eswitch inactive mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQ7MwqRiCsR6aNq3@x130>
Date: Fri, 7 Nov 2025 20:53:22 -0800
From: Saeed Mahameed <saeed@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
	Tariq Toukan <tariqt@...dia.com>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>, Jiri Pirko <jiri@...dia.com>,
	mbloch@...dia.com, Adithya Jayachandran <ajayachandra@...dia.com>
Subject: Re: [PATCH net-next V2 3/3] net/mlx5: E-Switch, support eswitch
 inactive mode

On 07 Nov 18:28, Jakub Kicinski wrote:
>On Thu,  6 Nov 2025 16:08:31 -0800 Saeed Mahameed wrote:
>> +	if (IS_ERR(table)) {
>> +		esw_warn(dev, "Failed to create fdb drop root table, err %ld\n",
>> +			 PTR_ERR(table));
>> +		return PTR_ERR(table);
>> +	}
>
>cocci says:
>
>drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:2397:4-11: WARNING: Consider using %pe to print PTR_ERR()
>

I was planing to do this now, but then saw your message bellow :).

>While I have you, could you please help this one along (dare I say,
>first, due to the extack propagation?):

Sure, what do you need just review? I see that the series is straight
forward, but let me take a deeper look.

>https://lore.kernel.org/all/20251107204347.4060542-1-daniel.zahka@gmail.com/