netdev - Re: [PATCH net v4 1/4] virtio-net: fix incorrect flags recording in big mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aoiyv6uhkup4fjjrbdplwulmhxivpdxfw5cisgxhdideiomjrd@7cu6uhkfqoxx>
Date: Sun, 9 Nov 2025 18:04:47 +0100
From: Alyssa Ross <hi@...ssa.is>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, "Michael S. Tsirkin" <mst@...hat.com>, 
	Jason Wang <jasowang@...hat.com>, Eugenio Pérez <eperezma@...hat.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Heng Qi <hengqi@...ux.alibaba.com>, 
	Willem de Bruijn <willemb@...gle.com>, Jiri Pirko <jiri@...nulli.us>, 
	Alvaro Karsz <alvaro.karsz@...id-run.com>, virtualization@...ts.linux.dev
Subject: Re: [PATCH net v4 1/4] virtio-net: fix incorrect flags recording in
 big mode

On Wed, Oct 29, 2025 at 11:09:10AM +0800, Xuan Zhuo wrote:
> The purpose of commit 703eec1b2422 ("virtio_net: fixing XDP for fully
> checksummed packets handling") is to record the flags in advance, as
> their value may be overwritten in the XDP case. However, the flags
> recorded under big mode are incorrect, because in big mode, the passed
> buf does not point to the rx buffer, but rather to the page of the
> submitted buffer. This commit fixes this issue.
>
> For the small mode, the commit c11a49d58ad2 ("virtio_net: Fix mismatched
> buf address when unmapping for small packets") fixed it.
>
> Fixes: 703eec1b2422 ("virtio_net: fixing XDP for fully checksummed packets handling")
> Signed-off-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
> Acked-by: Jason Wang <jasowang@...hat.com>
> ---
>  drivers/net/virtio_net.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)

Fixes my networking with CSUM offload enabled in Cloud Hypervisor, thanks!

Tested-by: Alyssa Ross <hi@...ssa.is>

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)