netdev - Re: [PATCH net 1/2] net/sched: Abort __tc_modify_qdisc if parent is a clsact/ingress qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRJrJyjyif/axyxf@pop-os.localdomain>
Date: Mon, 10 Nov 2025 14:45:59 -0800
From: Cong Wang <xiyou.wangcong@...il.com>
To: Victor Nogueira <victor@...atatu.com>
Cc: jhs@...atatu.com, jiri@...nulli.us, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, netdev@...r.kernel.org, wangliang74@...wei.com,
	pctammela@...atatu.ai
Subject: Re: [PATCH net 1/2] net/sched: Abort __tc_modify_qdisc if parent is
 a clsact/ingress qdisc

On Thu, Nov 06, 2025 at 05:56:20PM -0300, Victor Nogueira wrote:
> Wang reported an illegal configuration [1] where the user attempts to add a
> child qdisc to the ingress qdisc as follows:
> 
> tc qdisc add dev eth0 handle ffff:0 ingress
> tc qdisc add dev eth0 handle ffe0:0 parent ffff:a fq
> 
> To solve this, we reject any configuration attempt to add a child qdisc to
> ingress or clsact.
> 
> [1] https://lore.kernel.org/netdev/20251105022213.1981982-1-wangliang74@huawei.com/
> 
> Fixes: 5e50da01d0ce ("[NET_SCHED]: Fix endless loops (part 2): "simple" qdiscs")
> Reported-by: Wang Liang <wangliang74@...wei.com>
> Closes: https://lore.kernel.org/netdev/20251105022213.1981982-1-wangliang74@huawei.com/
> Reviewed-by: Pedro Tammela <pctammela@...atatu.ai>
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Victor Nogueira <victor@...atatu.com>

Reviewed-by: Cong Wang <cwang@...tikernel.io>

Thanks!