netdev - Re: [PATCH net-next v3 2/2] net/mlx5: implement swp_l4_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251110150133.04a2e905@kernel.org>
Date: Mon, 10 Nov 2025 15:01:33 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Saeed Mahameed <saeed@...nel.org>
Cc: Daniel Zahka <daniel.zahka@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Jonathan Corbet <corbet@....net>, Srujana Challa
 <schalla@...vell.com>, Bharat Bhushan <bbhushan2@...vell.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, Brett Creeley <brett.creeley@....com>,
 Andrew Lunn <andrew+netdev@...n.ch>, Michael Chan
 <michael.chan@...adcom.com>, Pavan Chebbi <pavan.chebbi@...adcom.com>, Tony
 Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Sunil Goutham <sgoutham@...vell.com>, Linu
 Cherian <lcherian@...vell.com>, Geetha sowjanya <gakula@...vell.com>, Jerin
 Jacob <jerinj@...vell.com>, hariprasad <hkelam@...vell.com>, Subbaraya
 Sundeep <sbhatta@...vell.com>, Tariq Toukan <tariqt@...dia.com>, Saeed
 Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, Mark Bloch
 <mbloch@...dia.com>, Ido Schimmel <idosch@...dia.com>, Petr Machata
 <petrm@...dia.com>, Manish Chopra <manishc@...vell.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Siddharth Vadapalli <s-vadapalli@...com>,
 Roger Quadros <rogerq@...nel.org>, Loic Poulain
 <loic.poulain@....qualcomm.com>, Sergey Ryazanov <ryazanov.s.a@...il.com>,
 Johannes Berg <johannes@...solutions.net>, Vladimir Oltean
 <olteanv@...il.com>, Michal Swiatkowski
 <michal.swiatkowski@...ux.intel.com>, Aleksandr Loktionov
 <aleksandr.loktionov@...el.com>, Dave Ertman <david.m.ertman@...el.com>,
 Vlad Dumitrescu <vdumitrescu@...dia.com>, "Russell King (Oracle)"
 <rmk+kernel@...linux.org.uk>, Alexander Sverdlin
 <alexander.sverdlin@...il.com>, Lorenzo Bianconi <lorenzo@...nel.org>,
 netdev@...r.kernel.org, linux-doc@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, linux-rdma@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/2] net/mlx5: implement swp_l4_csum_mode
 via devlink params

On Fri, 7 Nov 2025 22:14:45 -0800 Saeed Mahameed wrote:
> >+	err = mlx5_nv_param_read_sw_accelerate_conf(dev, mnvda, sizeof(mnvda));
> >+	if (err) {
> >+		NL_SET_ERR_MSG_MOD(extack,
> >+				   "Failed to read sw_accelerate_conf mnvda reg");  
> 
> Plug in the err, NL_SET_ERR_MSG_FMT_MOD(.., .., err);
> other locations as well.

Incorrect. extack should basically be passed to perror()
IOW user space will add strerror(errno) after, anyway.
Adding the errno inside the string is pointless and ugly.