netdev - Re: [PATCH net-next v2 1/2] bnx2x: convert to use ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a91d75b-3ba7-47be-9176-5d2245ac4fd5@intel.com>
Date: Mon, 10 Nov 2025 15:23:23 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Jakub Kicinski
	<kuba@...nel.org>
CC: Manish Chopra <manishc@...vell.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>,
	Simon Horman <horms@...nel.org>, Kory Maincent <kory.maincent@...tlin.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 1/2] bnx2x: convert to use ndo_hwtstamp
 callbacks



On 11/8/2025 4:38 AM, Vadim Fedorenko wrote:
> On 08/11/2025 02:41, Jakub Kicinski wrote:
>> On Thu,  6 Nov 2025 21:37:16 +0000 Vadim Fedorenko wrote:
>>> +	switch (config->tx_type) {
>>> +	case HWTSTAMP_TX_ONESTEP_SYNC:
>>> +	case HWTSTAMP_TX_ONESTEP_P2P:
>>> +		NL_SET_ERR_MSG_MOD(extack,
>>> +				   "One-step timestamping is not supported");
>>> +		return -ERANGE;
>>> +	default:
>>> +		break;
>>> +	}
>>
>> This is the wrong way around, if someone adds a new value unsupported
>> by the driver it will pass. We should be listing the supported types
>> and
>>
>> 	default:
>> 		...ERR_MSG..
>> 		return -ERANGE;
>> 	}
> 
> But that's the original logic of the driver. Should I change it within
> the same patch, or is it better to make a follow-up work to clean such
> things in net-next?

I'd prefer a separate patch for clarity. A backport is probably
unnecessary since I doubt we'll add a new timestamp mode in such a
backport in the future.. but functional changes like that make sense as
a separate patch.

Thanks,
Jake


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)